Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1276)

Issue 2256213002: Set min SDK for ManageSpaceActivityTest. (Closed)

Created:
4 years, 4 months ago by Torne
Modified:
4 years, 4 months ago
Reviewers:
Finnur
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set min SDK for ManageSpaceActivityTest. ManageSpaceActivity is only supported on K and above, but didn't have the correct annotation to tell the test runner to skip it on JB devices. We hadn't noticed this until recently as the JB test bot was incorrectly provisioned with K devices :( BUG=638927 Committed: https://crrev.com/e4f29ff78ccfdb1243d07e4c88b4812833d06770 Cr-Commit-Position: refs/heads/master@{#412833}

Patch Set 1 #

Patch Set 2 : Actually compile things before uploading them, whoops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/ManageSpaceActivityTest.java View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Torne
4 years, 4 months ago (2016-08-18 11:35:11 UTC) #2
Torne
oops, added missing import to fix compile. should really compile before uploading :)
4 years, 4 months ago (2016-08-18 13:10:42 UTC) #7
Finnur
LGTM
4 years, 4 months ago (2016-08-18 14:46:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256213002/20001
4 years, 4 months ago (2016-08-18 14:47:30 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-18 15:30:04 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 15:31:27 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e4f29ff78ccfdb1243d07e4c88b4812833d06770
Cr-Commit-Position: refs/heads/master@{#412833}

Powered by Google App Engine
This is Rietveld 408576698