Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2256203002: Ensure metadata on imports/exports is resolved for serialization. (Closed)

Created:
4 years, 4 months ago by Johnni Winther
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ensure metadata on imports/exports is resolved for serialization. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/da12e0695358db75bf77621f20253e9274a3b886

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -13 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 1 13 chunks +5 lines, -13 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_data.dart View 1 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 4 months ago (2016-08-18 11:11:42 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2256203002/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/2256203002/diff/1/pkg/compiler/lib/src/compiler.dart#newcode907 pkg/compiler/lib/src/compiler.dart:907: for (MetadataAnnotation metadata in import.metadata) { how about ...
4 years, 4 months ago (2016-08-18 15:28:17 UTC) #3
Johnni Winther
https://codereview.chromium.org/2256203002/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/2256203002/diff/1/pkg/compiler/lib/src/compiler.dart#newcode907 pkg/compiler/lib/src/compiler.dart:907: for (MetadataAnnotation metadata in import.metadata) { On 2016/08/18 15:28:17, ...
4 years, 4 months ago (2016-08-19 08:16:54 UTC) #4
Johnni Winther
4 years, 4 months ago (2016-08-19 08:44:26 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
da12e0695358db75bf77621f20253e9274a3b886 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698