ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc - Issue 2256193002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc

Issue 2256193002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/suggestions/suggestions_service_factory.mm ('k') | ios/chrome/browser/sync/ios_chrome_profile_sync_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc

diff --git a/ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc b/ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc

index 132d71d33c8cad16522b56d9d698feaaef210c1b..c11cb76ec0c5ff4a9751b2d1488ba4e98e47be49 100644

--- a/ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc

+++ b/ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc

@@ -128,13 +128,12 @@ IOSChromeProfileSyncServiceFactory::BuildServiceInstanceFor(

ios::AboutSigninInternalsFactory::GetForBrowserState(browser_state);

ProfileSyncService::InitParams init_params;

- init_params.signin_wrapper =

- base::WrapUnique(new SigninManagerWrapper(signin));

+ init_params.signin_wrapper = base::MakeUnique<SigninManagerWrapper>(signin);

init_params.oauth2_token_service =

OAuth2TokenServiceFactory::GetForBrowserState(browser_state);

init_params.start_behavior = ProfileSyncService::MANUAL_START;

init_params.sync_client =

- base::WrapUnique(new IOSChromeSyncClient(browser_state));

+ base::MakeUnique<IOSChromeSyncClient>(browser_state);

init_params.network_time_update_callback = base::Bind(&UpdateNetworkTime);

init_params.base_directory = browser_state->GetStatePath();

init_params.url_request_context = browser_state->GetRequestContext();

@@ -146,7 +145,7 @@ IOSChromeProfileSyncServiceFactory::BuildServiceInstanceFor(

web::WebThread::GetTaskRunnerForThread(web::WebThread::FILE);

init_params.blocking_pool = web::WebThread::GetBlockingPool();

- auto pss = base::WrapUnique(new ProfileSyncService(std::move(init_params)));

+ auto pss = base::MakeUnique<ProfileSyncService>(std::move(init_params));

// Will also initialize the sync client.

pss->Initialize();