ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.mm - Issue 2256193002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.mm

Issue 2256193002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ios_chrome_main_parts.mm ('k') | ios/chrome/browser/metrics/ios_chrome_origins_seen_service_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.mm

diff --git a/ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.mm b/ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.mm

index c94fc370c59ada87f364efd648cb75c6f6179a61..524fb3792198f7cac0023e1611d72a85d9c3a9c1 100644

--- a/ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.mm

+++ b/ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.mm

@@ -57,8 +57,8 @@ IOSChromeMetricsServicesManagerClient::

std::unique_ptr<rappor::RapporService>

IOSChromeMetricsServicesManagerClient::CreateRapporService() {

DCHECK(thread_checker_.CalledOnValidThread());

- return base::WrapUnique(new rappor::RapporService(

- local_state_, base::Bind(&::IsOffTheRecordSessionActive)));

+ return base::MakeUnique<rappor::RapporService>(

+ local_state_, base::Bind(&::IsOffTheRecordSessionActive));

}

std::unique_ptr<variations::VariationsService>