ios/chrome/browser/history/history_service_factory.cc - Issue 2256193002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/history/history_service_factory.cc

Issue 2256193002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/history/history_client_impl.cc ('k') | ios/chrome/browser/history/web_history_service_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/history/history_service_factory.cc

diff --git a/ios/chrome/browser/history/history_service_factory.cc b/ios/chrome/browser/history/history_service_factory.cc

index 965c10a9746d83e1fa70345b220929c8433f71bc..55d0390a906cfbf335a0a406beb6b5a1e799d2a1 100644

--- a/ios/chrome/browser/history/history_service_factory.cc

+++ b/ios/chrome/browser/history/history_service_factory.cc

@@ -74,8 +74,8 @@ std::unique_ptr<KeyedService> HistoryServiceFactory::BuildServiceInstanceFor(

ios::ChromeBrowserState::FromBrowserState(context);

std::unique_ptr<history::HistoryService> history_service(

new history::HistoryService(

- base::WrapUnique(new HistoryClientImpl(

- ios::BookmarkModelFactory::GetForBrowserState(browser_state))),

+ base::MakeUnique<HistoryClientImpl>(

+ ios::BookmarkModelFactory::GetForBrowserState(browser_state)),

nullptr));

if (!history_service->Init(history::HistoryDatabaseParamsForPath(

browser_state->GetStatePath()))) {

« no previous file with comments | « ios/chrome/browser/history/history_client_impl.cc ('k') | ios/chrome/browser/history/web_history_service_factory.cc » ('j') | no next file with comments »