ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc - Issue 2256193002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc

Issue 2256193002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.mm ('k') | ios/chrome/browser/browser_state/test_chrome_browser_state.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc

diff --git a/ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc b/ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc

index b79b2b0575ba4fa612792958d971bea07d781e89..273970113d7e3071f2b95001cc0ef83b574311e6 100644

--- a/ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc

+++ b/ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc

@@ -401,18 +401,18 @@ ChromeBrowserStateIOData::SetUpJobFactoryDefaults(

// ChromeBrowserStateIOData::IsHandledProtocol().

bool set_protocol = job_factory->SetProtocolHandler(

url::kFileScheme,

- base::WrapUnique(new net::FileProtocolHandler(

+ base::MakeUnique<net::FileProtocolHandler>(

web::WebThread::GetBlockingPool()->GetTaskRunnerWithShutdownBehavior(

- base::SequencedWorkerPool::SKIP_ON_SHUTDOWN))));

+ base::SequencedWorkerPool::SKIP_ON_SHUTDOWN)));

DCHECK(set_protocol);

set_protocol = job_factory->SetProtocolHandler(

- url::kDataScheme, base::WrapUnique(new net::DataProtocolHandler()));

+ url::kDataScheme, base::MakeUnique<net::DataProtocolHandler>());

DCHECK(set_protocol);

job_factory->SetProtocolHandler(

url::kAboutScheme,

- base::WrapUnique(new about_handler::AboutProtocolHandler()));

+ base::MakeUnique<about_handler::AboutProtocolHandler>());

// Set up interceptors in the reverse order.

std::unique_ptr<net::URLRequestJobFactory> top_job_factory =