Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2256183005: Reduce TokenDesc size by 20% on 64b platforms. (Closed)

Created:
4 years, 4 months ago by vogelheim
Modified:
4 years, 4 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reduce TokenDesc size by 20% on 64b platforms. (40B -> 32B, due to alignment rules. Should be neutral on 32b platforms.) BUG=v8:4947 Committed: https://crrev.com/8ff52750ed618080cc70d31f08c3cb8b8941c77d Cr-Commit-Position: refs/heads/master@{#38794}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/parsing/scanner.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
vogelheim
4 years, 4 months ago (2016-08-19 12:33:47 UTC) #2
marja
lgtm
4 years, 4 months ago (2016-08-22 08:07:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256183005/1
4 years, 4 months ago (2016-08-22 16:29:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 16:58:01 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 16:58:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ff52750ed618080cc70d31f08c3cb8b8941c77d
Cr-Commit-Position: refs/heads/master@{#38794}

Powered by Google App Engine
This is Rietveld 408576698