Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h

Issue 2256183004: Use bookmark creation date fallback for 6 weeks after installing M54 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make another DCHECK more readable Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h
diff --git a/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h b/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h
index 18f544298ce3a7a282a10f7bdcf4b3f1bf73b2cf..4666acda1f6eb900f11c086b19b17131d8bf7194 100644
--- a/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h
+++ b/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h
@@ -31,13 +31,13 @@ void UpdateBookmarkOnURLVisitedInMainFrame(
// bookmark is created also counts. If no info about last visit date is present
// and |creation_date_fallback| is true, creation date is used.
base::Time GetLastVisitDateForBookmark(const bookmarks::BookmarkNode* node,
- bool creation_date_fallback = true);
+ bool creation_date_fallback);
// Like GetLastVisitDateForBookmark, but it returns the unix epoch if the
// bookmark is dismissed from NTP.
base::Time GetLastVisitDateForBookmarkIfNotDismissed(
const bookmarks::BookmarkNode* node,
- bool creation_date_fallback = true);
+ bool creation_date_fallback);
// Marks all bookmarks with the given URL as dismissed.
void MarkBookmarksDismissed(bookmarks::BookmarkModel* bookmark_model,
@@ -59,7 +59,8 @@ std::vector<const bookmarks::BookmarkNode*> GetRecentlyVisitedBookmarks(
bookmarks::BookmarkModel* bookmark_model,
int min_count,
int max_count,
- const base::Time& min_visit_time);
+ const base::Time& min_visit_time,
+ bool creation_date_fallback);
// Returns the list of all dismissed bookmarks. Only used for debugging.
std::vector<const bookmarks::BookmarkNode*> GetDismissedBookmarksForDebugging(
« no previous file with comments | « chrome/browser/prefs/browser_prefs.cc ('k') | components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698