content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc - Issue 2256173002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc

Issue 2256173002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace a WrapUnique() nested inside a MakeUnique() Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_process_manager_unittest.cc ('k') | content/browser/service_worker/service_worker_url_request_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc

diff --git a/content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc b/content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc

index 4964b3836f62cffb1e94dbad225340de602b3e2c..b903a386a0db2f3b9cc061f2a4e37dc1d8ad7a71 100644

--- a/content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc

+++ b/content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc

@@ -194,10 +194,10 @@ TEST_F(ServiceWorkerReadFromCacheJobTest, ReadMainScript) {

url_request_context_->CreateRequest(main_script_.url,

net::DEFAULT_PRIORITY, &delegate_);

test_job_interceptor_->set_main_intercept_job(

- base::WrapUnique(new ServiceWorkerReadFromCacheJob(

+ base::MakeUnique<ServiceWorkerReadFromCacheJob>(

request.get(), nullptr /* NetworkDelegate */,

RESOURCE_TYPE_SERVICE_WORKER, context()->AsWeakPtr(), version_,

- main_script_.resource_id)));

+ main_script_.resource_id));

StartAndWaitForRequest(request.get());

EXPECT_EQ(net::URLRequestStatus::SUCCESS, request->status().status());

@@ -212,9 +212,9 @@ TEST_F(ServiceWorkerReadFromCacheJobTest, ReadImportedScript) {

url_request_context_->CreateRequest(imported_script_.url,

net::DEFAULT_PRIORITY, &delegate_);

test_job_interceptor_->set_main_intercept_job(

- base::WrapUnique(new ServiceWorkerReadFromCacheJob(

+ base::MakeUnique<ServiceWorkerReadFromCacheJob>(

request.get(), nullptr /* NetworkDelegate */, RESOURCE_TYPE_SCRIPT,

- context()->AsWeakPtr(), version_, imported_script_.resource_id)));

+ context()->AsWeakPtr(), version_, imported_script_.resource_id));

StartAndWaitForRequest(request.get());

EXPECT_EQ(net::URLRequestStatus::SUCCESS, request->status().status());

@@ -233,10 +233,10 @@ TEST_F(ServiceWorkerReadFromCacheJobTest, ResourceNotFound) {

&delegate_);

const int64_t kNonexistentResourceId = 100;

test_job_interceptor_->set_main_intercept_job(

- base::WrapUnique(new ServiceWorkerReadFromCacheJob(

+ base::MakeUnique<ServiceWorkerReadFromCacheJob>(

request.get(), nullptr /* NetworkDelegate */,

RESOURCE_TYPE_SERVICE_WORKER, context()->AsWeakPtr(), version_,

- kNonexistentResourceId)));

+ kNonexistentResourceId));

StartAndWaitForRequest(request.get());

EXPECT_EQ(net::URLRequestStatus::FAILED, request->status().status());