content/browser/download/download_request_core.cc - Issue 2256173002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_request_core.cc

Issue 2256173002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace a WrapUnique() nested inside a MakeUnique() Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/dom_storage/dom_storage_context_wrapper.cc ('k') | content/browser/fileapi/dragged_file_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/download_request_core.cc

diff --git a/content/browser/download/download_request_core.cc b/content/browser/download/download_request_core.cc

index c834e7b4a95842c13235c74885cfc1879bfd0a7d..62dcff23d4ca995365b79729ea6ea4988bd134b6 100644

--- a/content/browser/download/download_request_core.cc

+++ b/content/browser/download/download_request_core.cc

@@ -136,8 +136,8 @@ std::unique_ptr<net::URLRequest> DownloadRequestCore::CreateRequestOnIOThread(

DCHECK(params->prefer_cache());

DCHECK_EQ("POST", params->method());

std::vector<std::unique_ptr<net::UploadElementReader>> element_readers;

- request->set_upload(base::WrapUnique(new net::ElementsUploadDataStream(

- std::move(element_readers), params->post_id())));

+ request->set_upload(base::MakeUnique<net::ElementsUploadDataStream>(

+ std::move(element_readers), params->post_id()));

}

int load_flags = request->load_flags();