content/browser/browser_main_loop.cc - Issue 2256173002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_main_loop.cc

Issue 2256173002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace a WrapUnique() nested inside a MakeUnique() Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/bluetooth/frame_connected_bluetooth_devices_unittest.cc ('k') | content/browser/cache_storage/cache_storage.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_main_loop.cc

diff --git a/content/browser/browser_main_loop.cc b/content/browser/browser_main_loop.cc

index bc64398dc3657889fda88908cc44b7f2c8fa3e5e..29d065317d6205c1db65ad59020e1263438e98d7 100644

--- a/content/browser/browser_main_loop.cc

+++ b/content/browser/browser_main_loop.cc

@@ -785,12 +785,12 @@ void BrowserMainLoop::CreateStartupTasks() {

// First time through, we really want to create all the tasks

if (!startup_task_runner_.get()) {

#if defined(OS_ANDROID)

- startup_task_runner_ = base::WrapUnique(

- new StartupTaskRunner(base::Bind(&BrowserStartupComplete),

- base::ThreadTaskRunnerHandle::Get()));

+ startup_task_runner_ = base::MakeUnique<StartupTaskRunner>(

+ base::Bind(&BrowserStartupComplete),

+ base::ThreadTaskRunnerHandle::Get());

#else

- startup_task_runner_ = base::WrapUnique(new StartupTaskRunner(

- base::Callback<void(int)>(), base::ThreadTaskRunnerHandle::Get()));

+ startup_task_runner_ = base::MakeUnique<StartupTaskRunner>(

+ base::Callback<void(int)>(), base::ThreadTaskRunnerHandle::Get());

#endif

StartupTask pre_create_threads =

base::Bind(&BrowserMainLoop::PreCreateThreads, base::Unretained(this));