content/browser/background_sync/background_sync_manager.cc - Issue 2256173002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/background_sync/background_sync_manager.cc

Issue 2256173002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace a WrapUnique() nested inside a MakeUnique() Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/appcache/appcache_storage_impl_unittest.cc ('k') | content/browser/blob_storage/blob_url_request_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/background_sync/background_sync_manager.cc

diff --git a/content/browser/background_sync/background_sync_manager.cc b/content/browser/background_sync/background_sync_manager.cc

index f9d819a709c407e8509b7ea8b200b9cb4beb5ee2..44b3aa5099d9e29e0dd70f6b9bc5b7bbacd6d6dc 100644

--- a/content/browser/background_sync/background_sync_manager.cc

+++ b/content/browser/background_sync/background_sync_manager.cc

@@ -528,8 +528,8 @@ void BackgroundSyncManager::RegisterDidAskForPermission(

base::ThreadTaskRunnerHandle::Get()->PostTask(

FROM_HERE,

base::Bind(callback, BACKGROUND_SYNC_STATUS_OK,

- base::Passed(base::WrapUnique(new BackgroundSyncRegistration(

- *existing_registration)))));

+ base::Passed(base::MakeUnique<BackgroundSyncRegistration>(

+ *existing_registration))));

return;

}

@@ -700,8 +700,8 @@ void BackgroundSyncManager::RegisterDidStore(

base::ThreadTaskRunnerHandle::Get()->PostTask(

FROM_HERE,

base::Bind(callback, BACKGROUND_SYNC_STATUS_OK,

- base::Passed(base::WrapUnique(

- new BackgroundSyncRegistration(new_registration)))));

+ base::Passed(base::MakeUnique<BackgroundSyncRegistration>(

+ new_registration))));

}

void BackgroundSyncManager::RemoveActiveRegistration(int64_t sw_registration_id,