content/browser/appcache/appcache_request_handler_unittest.cc - Issue 2256173002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/appcache/appcache_request_handler_unittest.cc

Issue 2256173002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace a WrapUnique() nested inside a MakeUnique() Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/overscroll_controller_android.cc ('k') | content/browser/appcache/appcache_storage_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/appcache/appcache_request_handler_unittest.cc

diff --git a/content/browser/appcache/appcache_request_handler_unittest.cc b/content/browser/appcache/appcache_request_handler_unittest.cc

index 383ebc83d865e5dce31c41cc8675665b21261f15..1252bf190611dd870804365f8c271dd6df07eb72 100644

--- a/content/browser/appcache/appcache_request_handler_unittest.cc

+++ b/content/browser/appcache/appcache_request_handler_unittest.cc

@@ -380,9 +380,9 @@ class AppCacheRequestHandlerTest : public testing::Test {

}

void SimulateResponseCode(int response_code) {

- job_factory_->SetJob(base::WrapUnique(new MockURLRequestJob(

+ job_factory_->SetJob(base::MakeUnique<MockURLRequestJob>(

request_.get(), request_->context()->network_delegate(),

- response_code)));

+ response_code));

request_->Start();

// All our simulation needs to satisfy are the following two DCHECKs

DCHECK(request_->status().is_success());

@@ -390,8 +390,8 @@ class AppCacheRequestHandlerTest : public testing::Test {

}

void SimulateResponseInfo(const net::HttpResponseInfo& info) {

- job_factory_->SetJob(base::WrapUnique(new MockURLRequestJob(

- request_.get(), request_->context()->network_delegate(), info)));

+ job_factory_->SetJob(base::MakeUnique<MockURLRequestJob>(

+ request_.get(), request_->context()->network_delegate(), info));

request_->Start();

}