content/browser/appcache/appcache_storage_impl_unittest.cc - Issue 2256173002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/appcache/appcache_storage_impl_unittest.cc

Issue 2256173002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/appcache/appcache_request_handler_unittest.cc ('k') | content/browser/background_sync/background_sync_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/appcache/appcache_storage_impl_unittest.cc

diff --git a/content/browser/appcache/appcache_storage_impl_unittest.cc b/content/browser/appcache/appcache_storage_impl_unittest.cc

index a59be1c7e864bdce8db858915b0293ac665cfade..f05a761ffb46ac3f5fb82151570f4ca60d7c8889 100644

--- a/content/browser/appcache/appcache_storage_impl_unittest.cc

+++ b/content/browser/appcache/appcache_storage_impl_unittest.cc

@@ -168,8 +168,8 @@ class IOThread : public base::Thread {

std::unique_ptr<net::URLRequestJobFactoryImpl> factory(

new net::URLRequestJobFactoryImpl());

factory->SetProtocolHandler(

- "http", base::WrapUnique(new MockHttpServerJobFactory(

- base::WrapUnique(new AppCacheInterceptor()))));

+ "http", base::MakeUnique<MockHttpServerJobFactory>(

+ base::WrapUnique(new AppCacheInterceptor())));

clamy 2016/08/31 18:46:59 This second WrapUnique is not converted because Ap

Adam Rice 2016/09/01 11:25:14 While that kind of thing does happen a lot, in thi

job_factory_ = std::move(factory);

request_context_.reset(new net::TestURLRequestContext());

request_context_->set_job_factory(job_factory_.get());