Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Side by Side Diff: content/browser/streams/stream_url_request_job_unittest.cc

Issue 2256173002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Replace a WrapUnique() nested inside a MakeUnique() Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/streams/stream_url_request_job.h" 5 #include "content/browser/streams/stream_url_request_job.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "base/run_loop.h" 9 #include "base/run_loop.h"
10 #include "base/test/test_simple_task_runner.h" 10 #include "base/test/test_simple_task_runner.h"
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 private: 53 private:
54 StreamRegistry* registry_; 54 StreamRegistry* registry_;
55 }; 55 };
56 56
57 StreamURLRequestJobTest() {} 57 StreamURLRequestJobTest() {}
58 58
59 void SetUp() override { 59 void SetUp() override {
60 registry_.reset(new StreamRegistry()); 60 registry_.reset(new StreamRegistry());
61 61
62 url_request_job_factory_.SetProtocolHandler( 62 url_request_job_factory_.SetProtocolHandler(
63 "blob", base::WrapUnique(new MockProtocolHandler(registry_.get()))); 63 "blob", base::MakeUnique<MockProtocolHandler>(registry_.get()));
64 url_request_context_.set_job_factory(&url_request_job_factory_); 64 url_request_context_.set_job_factory(&url_request_job_factory_);
65 } 65 }
66 66
67 void TearDown() override {} 67 void TearDown() override {}
68 68
69 void TestSuccessRequest(const GURL& url, 69 void TestSuccessRequest(const GURL& url,
70 const std::string& expected_response) { 70 const std::string& expected_response) {
71 TestRequest("GET", url, net::HttpRequestHeaders(), 200, expected_response); 71 TestRequest("GET", url, net::HttpRequestHeaders(), 200, expected_response);
72 } 72 }
73 73
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 stream->AddData(buffer, buffer->size()); 173 stream->AddData(buffer, buffer->size());
174 stream->Finalize(); 174 stream->Finalize();
175 175
176 net::HttpRequestHeaders extra_headers; 176 net::HttpRequestHeaders extra_headers;
177 extra_headers.SetHeader(net::HttpRequestHeaders::kRange, 177 extra_headers.SetHeader(net::HttpRequestHeaders::kRange,
178 net::HttpByteRange::Bounded(1, 3).GetHeaderValue()); 178 net::HttpByteRange::Bounded(1, 3).GetHeaderValue());
179 TestRequest("GET", kStreamURL, extra_headers, 405, std::string()); 179 TestRequest("GET", kStreamURL, extra_headers, 405, std::string());
180 } 180 }
181 181
182 } // namespace content 182 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/storage_partition_impl_unittest.cc ('k') | content/browser/webui/url_data_manager_backend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698