Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Side by Side Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 2256173002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Replace a WrapUnique() nested inside a MakeUnique() Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/render_widget_host_impl.h" 5 #include "content/browser/renderer_host/render_widget_host_impl.h"
6 6
7 #include <math.h> 7 #include <math.h>
8 8
9 #include <set> 9 #include <set>
10 #include <tuple> 10 #include <tuple>
(...skipping 635 matching lines...) Expand 10 before | Expand all | Expand 10 after
646 g_check_for_pending_resize_ack && !resize_params->new_size.IsEmpty() && 646 g_check_for_pending_resize_ack && !resize_params->new_size.IsEmpty() &&
647 !resize_params->physical_backing_size.IsEmpty() && size_changed; 647 !resize_params->physical_backing_size.IsEmpty() && size_changed;
648 648
649 return dirty; 649 return dirty;
650 } 650 }
651 651
652 void RenderWidgetHostImpl::SetInitialRenderSizeParams( 652 void RenderWidgetHostImpl::SetInitialRenderSizeParams(
653 const ResizeParams& resize_params) { 653 const ResizeParams& resize_params) {
654 resize_ack_pending_ = resize_params.needs_resize_ack; 654 resize_ack_pending_ = resize_params.needs_resize_ack;
655 655
656 old_resize_params_ = base::WrapUnique(new ResizeParams(resize_params)); 656 old_resize_params_ = base::MakeUnique<ResizeParams>(resize_params);
657 } 657 }
658 658
659 void RenderWidgetHostImpl::WasResized() { 659 void RenderWidgetHostImpl::WasResized() {
660 // Skip if the |delegate_| has already been detached because 660 // Skip if the |delegate_| has already been detached because
661 // it's web contents is being deleted. 661 // it's web contents is being deleted.
662 if (resize_ack_pending_ || !process_->HasConnection() || !view_ || 662 if (resize_ack_pending_ || !process_->HasConnection() || !view_ ||
663 !renderer_initialized_ || auto_resize_enabled_ || !delegate_) { 663 !renderer_initialized_ || auto_resize_enabled_ || !delegate_) {
664 return; 664 return;
665 } 665 }
666 666
(...skipping 1541 matching lines...) Expand 10 before | Expand all | Expand 10 after
2208 return delegate_ ? delegate_->GetRootBrowserAccessibilityManager() : NULL; 2208 return delegate_ ? delegate_->GetRootBrowserAccessibilityManager() : NULL;
2209 } 2209 }
2210 2210
2211 BrowserAccessibilityManager* 2211 BrowserAccessibilityManager*
2212 RenderWidgetHostImpl::GetOrCreateRootBrowserAccessibilityManager() { 2212 RenderWidgetHostImpl::GetOrCreateRootBrowserAccessibilityManager() {
2213 return delegate_ ? 2213 return delegate_ ?
2214 delegate_->GetOrCreateRootBrowserAccessibilityManager() : NULL; 2214 delegate_->GetOrCreateRootBrowserAccessibilityManager() : NULL;
2215 } 2215 }
2216 2216
2217 } // namespace content 2217 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698