Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2256163002: [parser] Refactor preparser GetSymbol (Closed)

Created:
4 years, 4 months ago by nickie
Modified:
4 years, 4 months ago
Reviewers:
adamk, marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@nickie-2179423002-ref-traits
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] Refactor preparser GetSymbol R=adamk@chromium.org, marja@chromium.org BUG= LOG=N Committed: https://crrev.com/ed08838e564a2ae01f48e822de1237b74b1bcda8 Cr-Commit-Position: refs/heads/master@{#38738}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -31 lines) Patch
M src/parsing/preparser.cc View 1 chunk +27 lines, -31 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
nickie
4 years, 4 months ago (2016-08-18 10:11:55 UTC) #1
marja
lgtm
4 years, 4 months ago (2016-08-18 11:44:13 UTC) #6
adamk
lgtm
4 years, 4 months ago (2016-08-18 17:16:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256163002/1
4 years, 4 months ago (2016-08-19 08:12:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 08:14:24 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 08:14:36 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed08838e564a2ae01f48e822de1237b74b1bcda8
Cr-Commit-Position: refs/heads/master@{#38738}

Powered by Google App Engine
This is Rietveld 408576698