Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2256153002: WebFonts intervention v2: disable the feature on Android perf test (Closed)

Created:
4 years, 4 months ago by Takashi Toyoshima
Modified:
4 years, 4 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebFonts intervention v2: disable the feature on Android perf test Bisect suspected this CL as a culprit of a WebRTC tests performance regression. Let me revert this temporarily and see if the problem can be fixed by reverting this. BUG=636365 Committed: https://crrev.com/490513e0b74a3cc3e60a0719a30333e29768f34a Cr-Commit-Position: refs/heads/master@{#413053}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M testing/variations/fieldtrial_testing_config_android.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Takashi Toyoshima
PTAL: to investigate a perf regression, I'd disable this feature for a while.
4 years, 4 months ago (2016-08-18 08:25:16 UTC) #3
Ilya Sherman
LGTM as long as this is just a temporary revert.
4 years, 4 months ago (2016-08-18 19:39:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256153002/1
4 years, 4 months ago (2016-08-19 04:11:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 05:02:47 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/490513e0b74a3cc3e60a0719a30333e29768f34a Cr-Commit-Position: refs/heads/master@{#413053}
4 years, 4 months ago (2016-08-19 05:04:25 UTC) #10
Takashi Toyoshima
4 years, 4 months ago (2016-08-23 10:31:34 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2273633002/ by toyoshim@chromium.org.

The reason for reverting is: Investigation was finished..

Powered by Google App Engine
This is Rietveld 408576698