Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2256143002: Files app: Ignores pointer events on buttons on dialog footer. (Closed)

Created:
4 years, 4 months ago by fukino
Modified:
4 years, 4 months ago
Reviewers:
yamaguchi
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files app: Ignores pointer events on buttons on dialog footer. We should ignore pointer events on disabled buttons. It prevents unexpected command dispatches, and it is consistent with paper-button. BUG=632270 TEST=manually Committed: https://crrev.com/7fd6345280201363f55fc62ab6509842fa241042 Cr-Commit-Position: refs/heads/master@{#412812}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
fukino
PTAL. Thanks!
4 years, 4 months ago (2016-08-18 08:19:37 UTC) #2
yamaguchi
lgtm
4 years, 4 months ago (2016-08-18 12:31:23 UTC) #3
fukino
Thanks!
4 years, 4 months ago (2016-08-18 12:43:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256143002/1
4 years, 4 months ago (2016-08-18 12:44:14 UTC) #6
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing ...
4 years, 4 months ago (2016-08-18 13:32:50 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 13:33:39 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7fd6345280201363f55fc62ab6509842fa241042
Cr-Commit-Position: refs/heads/master@{#412812}

Powered by Google App Engine
This is Rietveld 408576698