Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2256103002:
Clear MainThreadLoaderHolder::m_workerLoader appropriately (Closed)
|
Created:
4 years, 4 months ago by yhirano Modified:
4 years, 4 months ago Reviewers:
haraken CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionClear MainThreadLoaderHolder::m_workerLoader appropriately
This CL fixes a violation for a DCHECK that states |m_workerLoader| should be
cleared before the MainThreadLoaderHolder's destruction.
BUG=635436
Committed: https://crrev.com/6ad8f516faa1db3a954d4beafa743eae5d588a5b
Cr-Commit-Position: refs/heads/master@{#412758}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 16 (10 generated)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
yhirano@chromium.org changed reviewers: + haraken@chromium.org
LGTM https://codereview.chromium.org/2256103002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp (right): https://codereview.chromium.org/2256103002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp:228: DCHECK(!m_client); Shall we add DCHECK(!m_workerLoader)?
Description was changed from ========== Clear WorkerThreadableLoader::m_workerLoader appropriately This CL fixes a violation for a DCHECK that states |m_workerLoader| should be cleared before the WorkerThreadableLoader's destruction. BUG=635436 ========== to ========== Clear WorkerThreadableLoader::MainThreadLoaderHolder::m_workerLoader appropriately This CL fixes a violation for a DCHECK that states |m_workerLoader| should be cleared before the MainThreadLoaderHolder's destruction. BUG=635436 ==========
Description was changed from ========== Clear WorkerThreadableLoader::MainThreadLoaderHolder::m_workerLoader appropriately This CL fixes a violation for a DCHECK that states |m_workerLoader| should be cleared before the MainThreadLoaderHolder's destruction. BUG=635436 ========== to ========== Clear MainThreadLoaderHolder::m_workerLoader appropriately This CL fixes a violation for a DCHECK that states |m_workerLoader| should be cleared before the MainThreadLoaderHolder's destruction. BUG=635436 ==========
https://codereview.chromium.org/2256103002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp (right): https://codereview.chromium.org/2256103002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp:228: DCHECK(!m_client); On 2016/08/18 04:58:37, haraken wrote: > > Shall we add DCHECK(!m_workerLoader)? Oops, the CL description was wrong. m_workerLoader is a WorkerThreadableLoader held by MainThreadLoaderHolder. MainThreadLoaderHolder already has the DCHECK. Fixed the CL description.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yhirano@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Clear MainThreadLoaderHolder::m_workerLoader appropriately This CL fixes a violation for a DCHECK that states |m_workerLoader| should be cleared before the MainThreadLoaderHolder's destruction. BUG=635436 ========== to ========== Clear MainThreadLoaderHolder::m_workerLoader appropriately This CL fixes a violation for a DCHECK that states |m_workerLoader| should be cleared before the MainThreadLoaderHolder's destruction. BUG=635436 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Clear MainThreadLoaderHolder::m_workerLoader appropriately This CL fixes a violation for a DCHECK that states |m_workerLoader| should be cleared before the MainThreadLoaderHolder's destruction. BUG=635436 ========== to ========== Clear MainThreadLoaderHolder::m_workerLoader appropriately This CL fixes a violation for a DCHECK that states |m_workerLoader| should be cleared before the MainThreadLoaderHolder's destruction. BUG=635436 Committed: https://crrev.com/6ad8f516faa1db3a954d4beafa743eae5d588a5b Cr-Commit-Position: refs/heads/master@{#412758} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6ad8f516faa1db3a954d4beafa743eae5d588a5b Cr-Commit-Position: refs/heads/master@{#412758} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
