components/arc: implement multi advertising

components/arc/bluetooth/bluetooth_type_converters.h

Index: components/arc/bluetooth/bluetooth_type_converters.h
diff --git a/components/arc/bluetooth/bluetooth_type_converters.h b/components/arc/bluetooth/bluetooth_type_converters.h
index 5c282dae78b523e4538f03f2f11d93b259c444e0..446770f142b3f2249c0c41a9b208e648dfa394d3 100644
--- a/components/arc/bluetooth/bluetooth_type_converters.h
+++ b/components/arc/bluetooth/bluetooth_type_converters.h
@@ -11,6 +11,7 @@
 #include <utility>
 
 #include "components/arc/common/bluetooth.mojom.h"
+#include "device/bluetooth/bluetooth_advertisement.h"
 #include "device/bluetooth/bluetooth_gatt_service.h"
 #include "mojo/public/cpp/bindings/type_converter.h"

[rickyz (no longer on Chrome), 2016/08/24 21:47:30]

I think the recommendation is to use type mapping instead of type converters for
new code: https://www.chromium.org/developers/design-documents/mojo/type-mapping

[Eric Caruso, 2016/08/24 22:24:42]

Type mapping forces me to write the chrome->mojo conversions as well, which is
going to be dead code, and for which the conversions don't necessarily make any
sense. For example, converting arc::mojom::BluetoothAdvertisementType to
device::BluetoothAdvertisement::AdvertisementType is a lossy conversion, so the
reverse conversion is ill-defined. The converter from
arc::mojom::BluetoothAdvertisement to device::BluetoothAdvertisement would be
well-defined but still code that is both complicated and dead.

[rickyz (no longer on Chrome), 2016/08/29 01:09:23]

I chatted with dcheng@, who asked one of the mojo folks, and it sounded like you
could get away with just not implementing the unneeded side of the conversion.
I'm not super familiar myself, but happy to figure the right folks to CC if this
ends up being a pain.

[Eric Caruso, 2016/08/29 17:24:52]

I did actually look into this before and it gave me compilation errors when I
only implemented e.g. FromMojom without ToMojom.

 
@@ -49,6 +50,20 @@ struct TypeConverter<arc::mojom::BluetoothGattStatus,
       const device::BluetoothGattService::GattErrorCode& error_code);
 };
 
+template <>
+struct TypeConverter<device::BluetoothAdvertisement::AdvertisementType,
+                     arc::mojom::BluetoothAdvertisementType> {
+  static device::BluetoothAdvertisement::AdvertisementType Convert(
+      const arc::mojom::BluetoothAdvertisementType& type);
+};
+
+template <>
+struct TypeConverter<std::unique_ptr<device::BluetoothAdvertisement::Data>,
+                     arc::mojom::BluetoothAdvertisementPtr> {
+  static std::unique_ptr<device::BluetoothAdvertisement::Data> Convert(
+      const arc::mojom::BluetoothAdvertisementPtr& advertisement);
+};
+
 }  // namespace mojo
 
 #endif  // COMPONENTS_ARC_BLUETOOTH_BLUETOOTH_TYPE_CONVERTERS_H_