Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: device/bluetooth/dbus/fake_bluetooth_le_advertising_manager_client.cc

Issue 2256003002: components/arc: implement multi advertising (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@plumb-incoming-connections
Patch Set: more testing Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/dbus/fake_bluetooth_le_advertising_manager_client.cc
diff --git a/device/bluetooth/dbus/fake_bluetooth_le_advertising_manager_client.cc b/device/bluetooth/dbus/fake_bluetooth_le_advertising_manager_client.cc
index f40f3d3ec545fa441b2b6fc9cad31f665c2687e6..e42267b03178d3aa08ba83c7ba3d55b0f71c3ce4 100644
--- a/device/bluetooth/dbus/fake_bluetooth_le_advertising_manager_client.cc
+++ b/device/bluetooth/dbus/fake_bluetooth_le_advertising_manager_client.cc
@@ -21,6 +21,8 @@ constexpr char kAdvertisingManagerPath[] = "/fake/hci0";
constexpr uint16_t kMinIntervalMs = 20;
constexpr uint16_t kMaxIntervalMs = 10240;
+constexpr size_t kMaxBluezAdvertisements = 5;
+
} // namespace
FakeBluetoothLEAdvertisingManagerClient::
@@ -53,11 +55,11 @@ void FakeBluetoothLEAdvertisingManagerClient::RegisterAdvertisement(
if (iter == service_provider_map_.end()) {
error_callback.Run(bluetooth_advertising_manager::kErrorInvalidArguments,
"Advertisement object not registered");
- } else if (!currently_registered_.value().empty()) {
+ } else if (currently_registered_.size() > kMaxBluezAdvertisements) {
Rahul Chaturvedi 2016/09/30 19:51:08 Should this be >=?
Eric Caruso 2016/09/30 20:08:29 Yep. Awkward.
error_callback.Run(bluetooth_advertising_manager::kErrorFailed,
"Maximum advertisements reached");
} else {
- currently_registered_ = advertisement_object_path;
+ currently_registered_.push_back(advertisement_object_path);
base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, callback);
}
}
@@ -74,16 +76,19 @@ void FakeBluetoothLEAdvertisingManagerClient::UnregisterAdvertisement(
return;
}
- ServiceProviderMap::iterator iter =
- service_provider_map_.find(advertisement_object_path);
- if (iter == service_provider_map_.end()) {
+ auto service_iter = service_provider_map_.find(advertisement_object_path);
+ auto reg_iter =
+ std::find(currently_registered_.begin(), currently_registered_.end(),
+ advertisement_object_path);
+
+ if (service_iter == service_provider_map_.end()) {
error_callback.Run(bluetooth_advertising_manager::kErrorDoesNotExist,
"Advertisement not registered");
- } else if (advertisement_object_path != currently_registered_) {
+ } else if (reg_iter == currently_registered_.end()) {
error_callback.Run(bluetooth_advertising_manager::kErrorDoesNotExist,
"Does not exist");
} else {
- currently_registered_ = dbus::ObjectPath("");
+ currently_registered_.erase(reg_iter);
base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, callback);
}
}

Powered by Google App Engine
This is Rietveld 408576698