Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 2255993002: Support call methods on functions (Closed)

Created:
4 years, 4 months ago by vsm
Modified:
4 years, 4 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add fix for dynamic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -12 lines) Patch
M lib/src/compiler/code_generator.dart View 1 2 chunks +28 lines, -10 lines 0 comments Download
A test/codegen/language/call_function_test.dart View 1 1 chunk +39 lines, -0 lines 0 comments Download
M test/codegen_expected/varargs.js View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
vsm
4 years, 4 months ago (2016-08-17 23:08:33 UTC) #3
Jennifer Messerly
assuming "dsend" works, then LGTM :) https://codereview.chromium.org/2255993002/diff/1/test/codegen/language/call_function_test.dart File test/codegen/language/call_function_test.dart (right): https://codereview.chromium.org/2255993002/diff/1/test/codegen/language/call_function_test.dart#newcode19 test/codegen/language/call_function_test.dart:19: Expect.equals(42, bar.call(42)); could ...
4 years, 4 months ago (2016-08-17 23:50:40 UTC) #4
vsm
On 2016/08/17 23:50:40, John Messerly wrote: > assuming "dsend" works, then LGTM :) > > ...
4 years, 4 months ago (2016-08-18 13:24:30 UTC) #5
Jennifer Messerly
lgtm!
4 years, 4 months ago (2016-08-18 14:28:03 UTC) #6
vsm
4 years, 4 months ago (2016-08-18 14:51:24 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3038a2baca9f4942e5a8bbd5330b9c01d2bddf7d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698