Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2255973003: Remove vulkan from most build variants (Closed)

Created:
4 years, 4 months ago by liyuqian
Modified:
4 years, 4 months ago
Reviewers:
jvanverth1, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove vulkan from most build variants Since many devices don't support vulkan, we have to remove it for most build variants and only turn it on manually by selecting arm64vulkan build variant. BUG=skia:5516 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255973003 Committed: https://skia.googlesource.com/skia/+/236e272380dcb30ad3ea009efe1be7f734dd6d8c

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M platform_tools/android/apps/build.gradle View 1 chunk +4 lines, -0 lines 0 comments Download
M platform_tools/android/apps/viewer/build.gradle View 1 chunk +2 lines, -2 lines 2 comments Download

Messages

Total messages: 13 (6 generated)
liyuqian
4 years, 4 months ago (2016-08-18 17:04:01 UTC) #4
djsollen
https://codereview.chromium.org/2255973003/diff/1/platform_tools/android/apps/viewer/build.gradle File platform_tools/android/apps/viewer/build.gradle (right): https://codereview.chromium.org/2255973003/diff/1/platform_tools/android/apps/viewer/build.gradle#newcode27 platform_tools/android/apps/viewer/build.gradle:27: productFlavors { arm {}; arm64 {}; x86 {}; x86_64 ...
4 years, 4 months ago (2016-08-22 16:07:59 UTC) #6
liyuqian
https://codereview.chromium.org/2255973003/diff/1/platform_tools/android/apps/viewer/build.gradle File platform_tools/android/apps/viewer/build.gradle (right): https://codereview.chromium.org/2255973003/diff/1/platform_tools/android/apps/viewer/build.gradle#newcode27 platform_tools/android/apps/viewer/build.gradle:27: productFlavors { arm {}; arm64 {}; x86 {}; x86_64 ...
4 years, 4 months ago (2016-08-22 18:05:41 UTC) #7
djsollen
thanks for the clarity. LGTM
4 years, 4 months ago (2016-08-22 19:04:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255973003/1
4 years, 4 months ago (2016-08-22 20:14:14 UTC) #10
liyuqian
On 2016/08/22 19:04:58, djsollen wrote: > thanks for the clarity. LGTM Thank you for the ...
4 years, 4 months ago (2016-08-22 20:14:45 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 20:37:00 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/236e272380dcb30ad3ea009efe1be7f734dd6d8c

Powered by Google App Engine
This is Rietveld 408576698