Remove vulkan from most build variants

Remove vulkan from most build variants

Since many devices don't support vulkan, we have to remove it for most
build variants and only turn it on manually by selecting arm64vulkan
build variant.

BUG=skia:5516
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255973003

Committed: https://skia.googlesource.com/skia/+/236e272380dcb30ad3ea009efe1be7f734dd6d8c

[liyuqian, 2016-08-18 15:24:53]

Description was changed from

==========
Remove vulkan from most build variants

Since many devices don't support vulkan, we have to remove it for most
build variants and only turn it on manually by selecting arm64vulkan
build variant.

BUG=skia:
==========

to

==========
Remove vulkan from most build variants

Since many devices don't support vulkan, we have to remove it for most
build variants and only turn it on manually by selecting arm64vulkan
build variant.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255973003
==========

[liyuqian, 2016-08-18 15:25:28]

Description was changed from

==========
Remove vulkan from most build variants

Since many devices don't support vulkan, we have to remove it for most
build variants and only turn it on manually by selecting arm64vulkan
build variant.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255973003
==========

to

==========
Remove vulkan from most build variants

Since many devices don't support vulkan, we have to remove it for most
build variants and only turn it on manually by selecting arm64vulkan
build variant.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255973003
==========

[liyuqian, 2016-08-18 15:25:28]

liyuqian@google.com changed reviewers:
+ djsollen@google.com, jvanverth@google.com

[liyuqian, 2016-08-18 17:04:23]

Description was changed from

==========
Remove vulkan from most build variants

Since many devices don't support vulkan, we have to remove it for most
build variants and only turn it on manually by selecting arm64vulkan
build variant.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255973003
==========

to

==========
Remove vulkan from most build variants

Since many devices don't support vulkan, we have to remove it for most
build variants and only turn it on manually by selecting arm64vulkan
build variant.

BUG=skia:5516
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255973003
==========

[djsollen, 2016-08-22 16:07:59]

https://codereview.chromium.org/2255973003/diff/1/platform_tools/android/apps...
File platform_tools/android/apps/viewer/build.gradle (right):

https://codereview.chromium.org/2255973003/diff/1/platform_tools/android/apps...
platform_tools/android/apps/viewer/build.gradle:27: productFlavors { arm {};
arm64 {}; x86 {}; x86_64 {}; mips {}; mips64 {}; arm64vulkan{}; }
so this works from gradle, but it if I build from the command line with --vulkan
-d arm64 will I get the arm64vulkan app?  What happens if I build for a device
other than arm64?

[liyuqian, 2016-08-22 18:05:41]

https://codereview.chromium.org/2255973003/diff/1/platform_tools/android/apps...
File platform_tools/android/apps/viewer/build.gradle (right):

https://codereview.chromium.org/2255973003/diff/1/platform_tools/android/apps...
platform_tools/android/apps/viewer/build.gradle:27: productFlavors { arm {};
arm64 {}; x86 {}; x86_64 {}; mips {}; mips64 {}; arm64vulkan{}; }
On 2016/08/22 16:07:59, djsollen wrote:
> so this works from gradle, but it if I build from the command line with
--vulkan
> -d arm64 will I get the arm64vulkan app?  What happens if I build for a device
> other than arm64?

Yes, "arm64vulkan" is equivalent to "--vulkan -d arm64" in command line. (The
new "arm64vulkan" is equivalent to our previous "arm64" variant.)

If we want to build vulkan on other variants, we could just create a new variant
with vulkan appended to the original variant (e.g., x86_64 -> x86_64vulkan).

[djsollen, 2016-08-22 19:04:58]

thanks for the clarity. LGTM

[liyuqian, 2016-08-22 20:14:01]

The CQ bit was checked by liyuqian@google.com

[commit-bot: I haz the power, 2016-08-22 20:14:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[liyuqian, 2016-08-22 20:14:45]

On 2016/08/22 19:04:58, djsollen wrote:
> thanks for the clarity. LGTM

Thank you for the quick review!

[commit-bot: I haz the power, 2016-08-22 20:37:00]

Description was changed from

==========
Remove vulkan from most build variants

Since many devices don't support vulkan, we have to remove it for most
build variants and only turn it on manually by selecting arm64vulkan
build variant.

BUG=skia:5516
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255973003
==========

to

==========
Remove vulkan from most build variants

Since many devices don't support vulkan, we have to remove it for most
build variants and only turn it on manually by selecting arm64vulkan
build variant.

BUG=skia:5516
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255973003

Committed:
https://skia.googlesource.com/skia/+/236e272380dcb30ad3ea009efe1be7f734dd6d8c
==========

[commit-bot: I haz the power, 2016-08-22 20:37:00]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/236e272380dcb30ad3ea009efe1be7f734dd6d8c