Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2255953002: [Extensions] Make ExtensionAPI use unique_ptrs instead of linked_ptrs (Closed)

Created:
4 years, 4 months ago by Devlin
Modified:
4 years, 4 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Make ExtensionAPI use unique_ptrs instead of linked_ptrs For the SchemaMap, use unique_ptrs instead of linked_ptrs. Also clean up the implementation a little. BUG=None Committed: https://crrev.com/6bf3cc8e81efd9ba28435a5aa53d06b5a439b03f Cr-Commit-Position: refs/heads/master@{#412688}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M extensions/common/extension_api.h View 2 chunks +2 lines, -3 lines 0 comments Download
M extensions/common/extension_api.cc View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Devlin
4 years, 4 months ago (2016-08-17 22:55:12 UTC) #6
lazyboy
lgtm
4 years, 4 months ago (2016-08-17 23:02:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255953002/1
4 years, 4 months ago (2016-08-17 23:06:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 23:24:15 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 23:35:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6bf3cc8e81efd9ba28435a5aa53d06b5a439b03f
Cr-Commit-Position: refs/heads/master@{#412688}

Powered by Google App Engine
This is Rietveld 408576698