EME: Remove obsolete legacy APIs related to versions of prefixed EME

EME: Remove obsolete legacy APIs related to versions of prefixed EME

Remove legacy_destination_url and LegacySessionError.

BUG=249976
TEST=existing tests

Committed: https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8
Cr-Commit-Position: refs/heads/master@{#413845}

[ddorwin, 2016-08-17 21:36:17]

The CQ bit was checked by ddorwin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 21:36:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 21:50:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 21:50:33]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ddorwin, 2016-08-18 00:21:11]

The CQ bit was checked by ddorwin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 00:21:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 03:58:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 03:58:12]

Dry run: This issue passed the CQ dry run.

[ddorwin, 2016-08-18 16:30:29]

ddorwin@chromium.org changed reviewers:
+ jrummell@chromium.org

[jrummell, 2016-08-18 19:10:43]

Looks good. Did you not want to remove the pepper call in
ppapi/api/private/ppb_content_decryptor_private.idl, or should that be done in a
separate CL?

https://codereview.chromium.org/2255943002/diff/40001/media/cdm/ppapi/ppapi_c...
File media/cdm/ppapi/ppapi_cdm_adapter.cc (right):

https://codereview.chromium.org/2255943002/diff/40001/media/cdm/ppapi/ppapi_c...
media/cdm/ppapi/ppapi_cdm_adapter.cc:700: PP_DCHECK(legacy_destination_url_size
== 0 ||
Since we're not passing |legacy_destination_url| on, should this check be
removed?

[ddorwin, 2016-08-18 19:21:48]

On 2016/08/18 19:10:43, jrummell wrote:
> Looks good. Did you not want to remove the pepper call in
> ppapi/api/private/ppb_content_decryptor_private.idl, or should that be done in
a
> separate CL?

I was avoiding changing PPAPI since it wasn't necessary. Since we don't support
backwards compatibility, there wouldn't be any extra effort, but there didn't
seem to be a compelling reason either. I could add a comment to the IDL files if
they don't already exist. WDYT?

https://codereview.chromium.org/2255943002/diff/40001/media/cdm/ppapi/ppapi_c...
File media/cdm/ppapi/ppapi_cdm_adapter.cc (right):

https://codereview.chromium.org/2255943002/diff/40001/media/cdm/ppapi/ppapi_c...
media/cdm/ppapi/ppapi_cdm_adapter.cc:700: PP_DCHECK(legacy_destination_url_size
== 0 ||
On 2016/08/18 19:10:43, jrummell wrote:
> Since we're not passing |legacy_destination_url| on, should this check be
> removed?

This is an assumption about the input from CDMs. It's probably not necessary,
but if a CDM did something different, that might be a problem we'd want to know
about. That's unlikely, but since this does not affect production, I think it's
fine to leave it until the bug above is addressed.

[jrummell, 2016-08-19 17:30:45]

lgtm

[ddorwin, 2016-08-19 18:32:02]

ddorwin@chromium.org changed reviewers:
+ alokp@chromium.org, dcheng@chromium.org, raymes@chromium.org

[ddorwin, 2016-08-19 18:32:03]

raymes: Please review changes in content/renderer/pepper/

alokp: Please review changes in chromecast/

dcheng: Please review content/common/media/cdm_messages.h and
media/mojo/interfaces/content_decryption_module.mojom

[dcheng, 2016-08-19 18:38:59]

ipc lgtm

delete ALL the legacy code

https://codereview.chromium.org/2255943002/diff/40001/media/cdm/ppapi/externa...
File media/cdm/ppapi/external_clear_key/clear_key_cdm.cc (right):

https://codereview.chromium.org/2255943002/diff/40001/media/cdm/ppapi/externa...
media/cdm/ppapi/external_clear_key/clear_key_cdm.cc:256: GURL empty_origin;
GURLs aren't origins =)

[ddorwin, 2016-08-19 18:54:16]

ddorwin@chromium.org changed reviewers:
+ halliwell@chromium.org
- alokp@chromium.org

[ddorwin, 2016-08-19 18:54:16]

halliwell: please review chromecast/

https://codereview.chromium.org/2255943002/diff/40001/media/cdm/ppapi/externa...
File media/cdm/ppapi/external_clear_key/clear_key_cdm.cc (right):

https://codereview.chromium.org/2255943002/diff/40001/media/cdm/ppapi/externa...
media/cdm/ppapi/external_clear_key/clear_key_cdm.cc:256: GURL empty_origin;
On 2016/08/19 18:38:59, dcheng wrote:
> GURLs aren't origins =)

Just being consistent with the TODO and constructor parameter. :)
Last I knew, we don't have a SecurityOrigin object like on the Blink side. If we
do, we should switch the types.

[dcheng, 2016-08-19 18:56:14]

https://codereview.chromium.org/2255943002/diff/40001/media/cdm/ppapi/externa...
File media/cdm/ppapi/external_clear_key/clear_key_cdm.cc (right):

https://codereview.chromium.org/2255943002/diff/40001/media/cdm/ppapi/externa...
media/cdm/ppapi/external_clear_key/clear_key_cdm.cc:256: GURL empty_origin;
On 2016/08/19 18:54:16, ddorwin wrote:
> On 2016/08/19 18:38:59, dcheng wrote:
> > GURLs aren't origins =)
> 
> Just being consistent with the TODO and constructor parameter. :)
> Last I knew, we don't have a SecurityOrigin object like on the Blink side. If
we
> do, we should switch the types.

Actually, we do now: url::Origin. To be clear though, I don't expect any changes
WRT url::Origin for this CL, since it's obviously out of scope.

[halliwell, 2016-08-19 19:03:27]

On 2016/08/19 18:56:14, dcheng wrote:
>
https://codereview.chromium.org/2255943002/diff/40001/media/cdm/ppapi/externa...
> File media/cdm/ppapi/external_clear_key/clear_key_cdm.cc (right):
> 
>
https://codereview.chromium.org/2255943002/diff/40001/media/cdm/ppapi/externa...
> media/cdm/ppapi/external_clear_key/clear_key_cdm.cc:256: GURL empty_origin;
> On 2016/08/19 18:54:16, ddorwin wrote:
> > On 2016/08/19 18:38:59, dcheng wrote:
> > > GURLs aren't origins =)
> > 
> > Just being consistent with the TODO and constructor parameter. :)
> > Last I knew, we don't have a SecurityOrigin object like on the Blink side.
If
> we
> > do, we should switch the types.
> 
> Actually, we do now: url::Origin. To be clear though, I don't expect any
changes
> WRT url::Origin for this CL, since it's obviously out of scope.

chromecast/ lgtm

[raymes, 2016-08-22 00:28:31]

lgtm

[ddorwin, 2016-08-22 16:34:00]

The CQ bit was checked by ddorwin@chromium.org

[commit-bot: I haz the power, 2016-08-22 16:34:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 18:38:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 18:38:06]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[ddorwin, 2016-08-22 20:16:06]

The CQ bit was checked by ddorwin@chromium.org

[commit-bot: I haz the power, 2016-08-22 20:16:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 22:58:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 22:58:26]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[ddorwin, 2016-08-23 19:05:27]

The CQ bit was checked by ddorwin@chromium.org

[commit-bot: I haz the power, 2016-08-23 19:05:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 21:36:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-23 21:39:57]

Description was changed from

==========
EME: Remove obsolete legacy APIs related to versions of prefixed EME

Remove legacy_destination_url and LegacySessionError.

BUG=249976
TEST=existing tests
==========

to

==========
EME: Remove obsolete legacy APIs related to versions of prefixed EME

Remove legacy_destination_url and LegacySessionError.

BUG=249976
TEST=existing tests

Committed: https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8
Cr-Commit-Position: refs/heads/master@{#413845}
==========

[commit-bot: I haz the power, 2016-08-23 21:39:59]

Patchset 3 (id:??) landed as
https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8
Cr-Commit-Position: refs/heads/master@{#413845}