third_party/WebKit/Source/modules/permissions/Permissions.h - Issue 2255933002: Add PermissionDescriptor to the permissions Mojo interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/permissions/Permissions.h

Issue 2255933002: Add PermissionDescriptor to the permissions Mojo interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no_notification_dispatcher

Patch Set: Addressed mlamouri@'s comments. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/permissions/PermissionUtils.cpp ('K') | « third_party/WebKit/Source/modules/permissions/PermissionUtils.cpp ('k') | third_party/WebKit/Source/modules/permissions/Permissions.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/permissions/Permissions.h

diff --git a/third_party/WebKit/Source/modules/permissions/Permissions.h b/third_party/WebKit/Source/modules/permissions/Permissions.h

index 5620cdc481ccffcd28da712d108b4935139b7f01..929162b9b5035056bf3955e0fa0aadd90748f826 100644

--- a/third_party/WebKit/Source/modules/permissions/Permissions.h

+++ b/third_party/WebKit/Source/modules/permissions/Permissions.h

@@ -25,9 +25,6 @@ class Permissions final

public:

DEFINE_INLINE_TRACE() { }

- // TODO(mlamouri): Find better place for this. https://crbug.com/510948

- static bool connectToService(ExecutionContext*, mojom::blink::PermissionServiceRequest);

ScriptPromise query(ScriptState*, const Dictionary&);

ScriptPromise request(ScriptState*, const Dictionary&);

ScriptPromise revoke(ScriptState*, const Dictionary&);

@@ -36,8 +33,8 @@ public:

private:

mojom::blink::PermissionService* getService(ExecutionContext*);

void serviceConnectionError();

- void taskComplete(ScriptPromiseResolver*, mojom::blink::PermissionName, mojom::blink::PermissionStatus);

- void batchTaskComplete(ScriptPromiseResolver*, Vector<mojom::blink::PermissionName>, Vector<int>, const Vector<mojom::blink::PermissionStatus>&);

+ void taskComplete(ScriptPromiseResolver*, mojom::blink::PermissionDescriptorPtr, mojom::blink::PermissionStatus);

+ void batchTaskComplete(ScriptPromiseResolver*, Vector<mojom::blink::PermissionDescriptorPtr>, Vector<int>, const Vector<mojom::blink::PermissionStatus>&);

mojom::blink::PermissionServicePtr m_service;

};