Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: third_party/WebKit/public/platform/modules/permissions/permission.mojom

Issue 2255933002: Add PermissionDescriptor to the permissions Mojo interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no_notification_dispatcher
Patch Set: Print the unexpected permission type. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/modules/permissions/permission.mojom
diff --git a/third_party/WebKit/public/platform/modules/permissions/permission.mojom b/third_party/WebKit/public/platform/modules/permissions/permission.mojom
index 7effb7cc25d78afa23150145a505d40ed2fa1492..ef429379f97c3836ee0ef8b504482fcac89ff004 100644
--- a/third_party/WebKit/public/platform/modules/permissions/permission.mojom
+++ b/third_party/WebKit/public/platform/modules/permissions/permission.mojom
@@ -12,7 +12,6 @@ enum PermissionName {
NOTIFICATIONS,
PUSH_NOTIFICATIONS,
MIDI,
- MIDI_SYSEX,
PROTECTED_MEDIA_IDENTIFIER,
DURABLE_STORAGE,
AUDIO_CAPTURE,
@@ -20,26 +19,42 @@ enum PermissionName {
BACKGROUND_SYNC,
};
+struct MidiPermissionDescriptor {
+ bool sysex;
+};
+
+// Union of possible extensions to the base PermissionDescriptor type.
+union PermissionDescriptorExtension {
+ MidiPermissionDescriptor midi;
+};
+
+// This struct roughly corresponds to the PermissionDescriptor dictionary as
+// defined by the Permissions API.
+struct PermissionDescriptor {
+ PermissionName name;
+ PermissionDescriptorExtension? extension;
+};
+
// The Permission service provides permission handling capabilities by exposing
// methods to check, request, and revoke permissions. It also allows a client to
// start listening to permission changes.
interface PermissionService {
- HasPermission(PermissionName permission, url.mojom.Origin origin)
+ HasPermission(PermissionDescriptor permission, url.mojom.Origin origin)
=> (PermissionStatus status);
- RequestPermission(PermissionName permission, url.mojom.Origin origin,
+ RequestPermission(PermissionDescriptor permission, url.mojom.Origin origin,
bool user_gesture)
=> (PermissionStatus status);
- RequestPermissions(array<PermissionName> permission, url.mojom.Origin origin,
+ RequestPermissions(array<PermissionDescriptor> permission, url.mojom.Origin origin,
bool user_gesture)
=> (array<PermissionStatus> statuses);
- RevokePermission(PermissionName permission, url.mojom.Origin origin)
+ RevokePermission(PermissionDescriptor permission, url.mojom.Origin origin)
=> (PermissionStatus status);
// Runs the callback next time there is a permission status change for the
// given { permission, origin }. Callers of this method will have to call it
// again if they want to keep listening to the changes. To prevent race
// conditions, the caller must pass the last known value.
- GetNextPermissionChange(PermissionName permission,
+ GetNextPermissionChange(PermissionDescriptor permission,
url.mojom.Origin origin,
PermissionStatus last_known_status)
=> (PermissionStatus status);
« no previous file with comments | « third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698