Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Unified Diff: third_party/WebKit/Source/modules/permissions/Permissions.h

Issue 2255933002: Add PermissionDescriptor to the permissions Mojo interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no_notification_dispatcher
Patch Set: Print the unexpected permission type. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/permissions/Permissions.h
diff --git a/third_party/WebKit/Source/modules/permissions/Permissions.h b/third_party/WebKit/Source/modules/permissions/Permissions.h
index c3cf9663b382a0269e7f38c8328e5f03c689b1e3..3c4cfbac34cc85cbacfa8a2710145c6d049aab25 100644
--- a/third_party/WebKit/Source/modules/permissions/Permissions.h
+++ b/third_party/WebKit/Source/modules/permissions/Permissions.h
@@ -25,10 +25,6 @@ class Permissions final : public GarbageCollectedFinalized<Permissions>,
public:
DEFINE_INLINE_TRACE() {}
- // TODO(mlamouri): Find better place for this. https://crbug.com/510948
- static bool connectToService(ExecutionContext*,
- mojom::blink::PermissionServiceRequest);
-
ScriptPromise query(ScriptState*, const Dictionary&);
ScriptPromise request(ScriptState*, const Dictionary&);
ScriptPromise revoke(ScriptState*, const Dictionary&);
@@ -38,10 +34,10 @@ class Permissions final : public GarbageCollectedFinalized<Permissions>,
mojom::blink::PermissionService* getService(ExecutionContext*);
void serviceConnectionError();
void taskComplete(ScriptPromiseResolver*,
- mojom::blink::PermissionName,
+ mojom::blink::PermissionDescriptorPtr,
mojom::blink::PermissionStatus);
void batchTaskComplete(ScriptPromiseResolver*,
- Vector<mojom::blink::PermissionName>,
+ Vector<mojom::blink::PermissionDescriptorPtr>,
Vector<int>,
const Vector<mojom::blink::PermissionStatus>&);

Powered by Google App Engine
This is Rietveld 408576698