third_party/WebKit/Source/modules/permissions/PermissionStatus.h - Issue 2255933002: Add PermissionDescriptor to the permissions Mojo interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/permissions/PermissionStatus.h

Issue 2255933002: Add PermissionDescriptor to the permissions Mojo interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no_notification_dispatcher

Patch Set: Print the unexpected permission type. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/permissions/BUILD.gn ('k') | third_party/WebKit/Source/modules/permissions/PermissionStatus.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/permissions/PermissionStatus.h

diff --git a/third_party/WebKit/Source/modules/permissions/PermissionStatus.h b/third_party/WebKit/Source/modules/permissions/PermissionStatus.h

index 75e0dddabd5675f8f56cd77ddfbf22fa27506e36..f93f8a4f2693e7ab26c8bb01ea2acb95a61fbe70 100644

--- a/third_party/WebKit/Source/modules/permissions/PermissionStatus.h

+++ b/third_party/WebKit/Source/modules/permissions/PermissionStatus.h

@@ -26,17 +26,17 @@ class PermissionStatus final : public EventTargetWithInlineData,

USING_GARBAGE_COLLECTED_MIXIN(PermissionStatus);

DEFINE_WRAPPERTYPEINFO();

- using MojoPermissionName = mojom::blink::PermissionName;

+ using MojoPermissionDescriptor = mojom::blink::PermissionDescriptorPtr;

using MojoPermissionStatus = mojom::blink::PermissionStatus;

public:

static PermissionStatus* take(ScriptPromiseResolver*,

MojoPermissionStatus,

- MojoPermissionName);

+ MojoPermissionDescriptor);

static PermissionStatus* createAndListen(ExecutionContext*,

MojoPermissionStatus,

- MojoPermissionName);

+ MojoPermissionDescriptor);

~PermissionStatus() override;

// EventTarget implementation.

@@ -52,20 +52,22 @@ class PermissionStatus final : public EventTargetWithInlineData,

void stop() override;

String state() const;

- void permissionChanged(mojom::blink::PermissionStatus);

+ void permissionChanged(MojoPermissionStatus);

DEFINE_ATTRIBUTE_EVENT_LISTENER(change);

DECLARE_VIRTUAL_TRACE();

private:

- PermissionStatus(ExecutionContext*, MojoPermissionStatus, MojoPermissionName);

+ PermissionStatus(ExecutionContext*,

+ MojoPermissionStatus,

+ MojoPermissionDescriptor);

void startListening();

void stopListening();

MojoPermissionStatus m_status;

- MojoPermissionName m_name;

+ MojoPermissionDescriptor m_descriptor;

mojom::blink::PermissionServicePtr m_service;

};