third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/geolocation-mock.js - Issue 2255933002: Add PermissionDescriptor to the permissions Mojo interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/geolocation-mock.js

Issue 2255933002: Add PermissionDescriptor to the permissions Mojo interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no_notification_dispatcher

Patch Set: Print the unexpected permission type. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/geolocation-mock.js

diff --git a/third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/geolocation-mock.js b/third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/geolocation-mock.js

index 9e8ef5b80809d7eff4d5174de69b2304b6acadeb..836c79d69e1f587a21de25b7a58d80172f77ed62 100644

--- a/third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/geolocation-mock.js

+++ b/third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/geolocation-mock.js

@@ -149,8 +149,8 @@ let geolocationServiceMock = loadMojoModules(

* for a call if necessary. Any permission request that is not for

* geolocation is always denied.

- requestPermission(permissionName) {

- if (permissionName != permission.PermissionName.GEOLOCATION)

+ requestPermission(permissionDescriptor) {

+ if (permissionDescriptor.name != permission.PermissionName.GEOLOCATION)

return Promise.resolve(permissionStatus.PermissionStatus.DENIED);

return new Promise(resolve => {

« no previous file with comments | « content/renderer/media/media_permission_dispatcher.cc ('k') | third_party/WebKit/Source/modules/geolocation/DEPS » ('j') | no next file with comments »