Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp

Issue 2255933002: Add PermissionDescriptor to the permissions Mojo interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no_notification_dispatcher
Patch Set: Demonstrate PermissionDescriptor extensibility with MIDI. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/webmidi/MIDIAccessInitializer.h" 5 #include "modules/webmidi/MIDIAccessInitializer.h"
6 6
7 #include "bindings/core/v8/ScriptPromise.h" 7 #include "bindings/core/v8/ScriptPromise.h"
8 #include "bindings/core/v8/ScriptPromiseResolver.h" 8 #include "bindings/core/v8/ScriptPromiseResolver.h"
9 #include "core/dom/DOMException.h" 9 #include "core/dom/DOMException.h"
10 #include "core/dom/Document.h" 10 #include "core/dom/Document.h"
11 #include "core/dom/ExceptionCode.h" 11 #include "core/dom/ExceptionCode.h"
12 #include "core/frame/LocalFrame.h" 12 #include "core/frame/LocalFrame.h"
13 #include "core/frame/Navigator.h" 13 #include "core/frame/Navigator.h"
14 #include "modules/webmidi/MIDIAccess.h" 14 #include "modules/webmidi/MIDIAccess.h"
15 #include "modules/webmidi/MIDIOptions.h" 15 #include "modules/webmidi/MIDIOptions.h"
16 #include "modules/webmidi/MIDIPort.h" 16 #include "modules/webmidi/MIDIPort.h"
17 #include "platform/UserGestureIndicator.h" 17 #include "platform/UserGestureIndicator.h"
18 #include "platform/mojo/MojoHelper.h" 18 #include "platform/mojo/MojoHelper.h"
19 #include "public/platform/InterfaceProvider.h" 19 #include "public/platform/InterfaceProvider.h"
20 #include "third_party/WebKit/public/platform/modules/permissions/permission.mojo m-blink.h" 20 #include "third_party/WebKit/public/platform/modules/permissions/permission.mojo m-blink.h"
21 21
22 namespace blink { 22 namespace blink {
23 23
24 using PortState = WebMIDIAccessorClient::MIDIPortState; 24 using PortState = WebMIDIAccessorClient::MIDIPortState;
25 25
26 using mojom::blink::PermissionName;
27 using mojom::blink::PermissionStatus; 26 using mojom::blink::PermissionStatus;
28 27
29 MIDIAccessInitializer::MIDIAccessInitializer(ScriptState* scriptState, const MID IOptions& options) 28 MIDIAccessInitializer::MIDIAccessInitializer(ScriptState* scriptState, const MID IOptions& options)
30 : ScriptPromiseResolver(scriptState) 29 : ScriptPromiseResolver(scriptState)
31 , m_options(options) 30 , m_options(options)
32 { 31 {
33 } 32 }
34 33
35 void MIDIAccessInitializer::contextDestroyed() 34 void MIDIAccessInitializer::contextDestroyed()
36 { 35 {
37 m_permissionService.reset(); 36 m_permissionService.reset();
38 LifecycleObserver::contextDestroyed(); 37 LifecycleObserver::contextDestroyed();
39 } 38 }
40 39
41 ScriptPromise MIDIAccessInitializer::start() 40 ScriptPromise MIDIAccessInitializer::start()
42 { 41 {
43 ScriptPromise promise = this->promise(); 42 ScriptPromise promise = this->promise();
44 m_accessor = MIDIAccessor::create(this); 43 m_accessor = MIDIAccessor::create(this);
45 44
46 Document* document = toDocument(getExecutionContext()); 45 Document* document = toDocument(getExecutionContext());
47 DCHECK(document); 46 DCHECK(document);
48 47
49 document->frame()->interfaceProvider()->getInterface(mojo::GetProxy(&m_permi ssionService)); 48 document->frame()->interfaceProvider()->getInterface(mojo::GetProxy(&m_permi ssionService));
50 49
51 bool requestSysEx = m_options.hasSysex() && m_options.sysex(); 50 auto permission = mojom::blink::PermissionDescriptor::New();
52 Vector<PermissionName> permissions; 51 permission->name = mojom::blink::PermissionName::MIDI;
53 permissions.resize(requestSysEx ? 2 : 1); 52 auto midiPermission = mojom::blink::MidiPermissionDescriptor::New();
53 midiPermission->sysex = m_options.hasSysex() && m_options.sysex();
54 permission->extension = mojom::blink::PermissionDescriptorExtension::New();
55 permission->extension->set_midi(std::move(midiPermission));
54 56
55 permissions[0] = PermissionName::MIDI; 57 m_permissionService->RequestPermission(
56 if (requestSysEx) 58 std::move(permission),
57 permissions[1] = PermissionName::MIDI_SYSEX;
58
59 m_permissionService->RequestPermissions(
60 permissions,
61 getExecutionContext()->getSecurityOrigin(), 59 getExecutionContext()->getSecurityOrigin(),
62 UserGestureIndicator::processingUserGesture(), 60 UserGestureIndicator::processingUserGesture(),
63 convertToBaseCallback(WTF::bind(&MIDIAccessInitializer::onPermissionsUpd ated, wrapPersistent(this)))); 61 convertToBaseCallback(WTF::bind(&MIDIAccessInitializer::onPermissionsUpd ated, wrapPersistent(this))));
64 62
65 return promise; 63 return promise;
66 } 64 }
67 65
68 void MIDIAccessInitializer::didAddInputPort(const String& id, const String& manu facturer, const String& name, const String& version, PortState state) 66 void MIDIAccessInitializer::didAddInputPort(const String& id, const String& manu facturer, const String& name, const String& version, PortState state)
69 { 67 {
70 DCHECK(m_accessor); 68 DCHECK(m_accessor);
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 } 114 }
117 reject(DOMException::create(ec, message)); 115 reject(DOMException::create(ec, message));
118 } 116 }
119 } 117 }
120 118
121 ExecutionContext* MIDIAccessInitializer::getExecutionContext() const 119 ExecutionContext* MIDIAccessInitializer::getExecutionContext() const
122 { 120 {
123 return getScriptState()->getExecutionContext(); 121 return getScriptState()->getExecutionContext();
124 } 122 }
125 123
126 void MIDIAccessInitializer::onPermissionsUpdated(const Vector<PermissionStatus>& statusArray) 124 void MIDIAccessInitializer::onPermissionsUpdated(PermissionStatus status)
127 { 125 {
128 bool allowed = true;
129 for (const auto status : statusArray) {
130 if (status != PermissionStatus::GRANTED) {
131 allowed = false;
132 break;
133 }
134 }
135 m_permissionService.reset(); 126 m_permissionService.reset();
136 if (allowed) 127 if (status == PermissionStatus::GRANTED)
137 m_accessor->startSession(); 128 m_accessor->startSession();
138 else 129 else
139 reject(DOMException::create(SecurityError)); 130 reject(DOMException::create(SecurityError));
140 131
141 } 132 }
142 133
143 void MIDIAccessInitializer::onPermissionUpdated(PermissionStatus status) 134 void MIDIAccessInitializer::onPermissionUpdated(PermissionStatus status)
144 { 135 {
145 m_permissionService.reset(); 136 m_permissionService.reset();
146 if (status == PermissionStatus::GRANTED) 137 if (status == PermissionStatus::GRANTED)
147 m_accessor->startSession(); 138 m_accessor->startSession();
148 else 139 else
149 reject(DOMException::create(SecurityError)); 140 reject(DOMException::create(SecurityError));
150 } 141 }
151 142
152 } // namespace blink 143 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698