Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: third_party/WebKit/Source/modules/notifications/NotificationManager.cpp

Issue 2255933002: Add PermissionDescriptor to the permissions Mojo interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no_notification_dispatcher
Patch Set: Print the unexpected permission type. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/notifications/NotificationManager.h" 5 #include "modules/notifications/NotificationManager.h"
6 6
7 #include "bindings/core/v8/ScriptPromiseResolver.h" 7 #include "bindings/core/v8/ScriptPromiseResolver.h"
8 #include "bindings/core/v8/ScriptState.h" 8 #include "bindings/core/v8/ScriptState.h"
9 #include "modules/notifications/Notification.h" 9 #include "modules/notifications/Notification.h"
10 #include "modules/notifications/NotificationPermissionCallback.h" 10 #include "modules/notifications/NotificationPermissionCallback.h"
11 #include "modules/permissions/Permissions.h" 11 #include "modules/permissions/PermissionUtils.h"
12 #include "platform/UserGestureIndicator.h" 12 #include "platform/UserGestureIndicator.h"
13 #include "platform/weborigin/SecurityOrigin.h" 13 #include "platform/weborigin/SecurityOrigin.h"
14 #include "public/platform/InterfaceProvider.h" 14 #include "public/platform/InterfaceProvider.h"
15 #include "public/platform/Platform.h" 15 #include "public/platform/Platform.h"
16 #include "public/platform/modules/permissions/permission.mojom-blink.h" 16 #include "public/platform/modules/permissions/permission.mojom-blink.h"
17 #include "public/platform/modules/permissions/permission_status.mojom-blink.h" 17 #include "public/platform/modules/permissions/permission_status.mojom-blink.h"
18 #include "wtf/Functional.h" 18 #include "wtf/Functional.h"
19 19
20 namespace blink { 20 namespace blink {
21 21
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 59
60 return permissionStatus; 60 return permissionStatus;
61 } 61 }
62 62
63 ScriptPromise NotificationManager::requestPermission( 63 ScriptPromise NotificationManager::requestPermission(
64 ScriptState* scriptState, 64 ScriptState* scriptState,
65 NotificationPermissionCallback* deprecatedCallback) { 65 NotificationPermissionCallback* deprecatedCallback) {
66 ExecutionContext* context = scriptState->getExecutionContext(); 66 ExecutionContext* context = scriptState->getExecutionContext();
67 67
68 if (!m_permissionService) { 68 if (!m_permissionService) {
69 Permissions::connectToService(context, 69 connectToPermissionService(context, mojo::GetProxy(&m_permissionService));
70 mojo::GetProxy(&m_permissionService));
71 m_permissionService.set_connection_error_handler(convertToBaseCallback( 70 m_permissionService.set_connection_error_handler(convertToBaseCallback(
72 WTF::bind(&NotificationManager::onPermissionServiceConnectionError, 71 WTF::bind(&NotificationManager::onPermissionServiceConnectionError,
73 wrapWeakPersistent(this)))); 72 wrapWeakPersistent(this))));
74 } 73 }
75 74
76 ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState); 75 ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
77 ScriptPromise promise = resolver->promise(); 76 ScriptPromise promise = resolver->promise();
78 77
79 m_permissionService->RequestPermission( 78 m_permissionService->RequestPermission(
80 mojom::blink::PermissionName::NOTIFICATIONS, context->getSecurityOrigin(), 79 createPermissionDescriptor(mojom::blink::PermissionName::NOTIFICATIONS),
80 context->getSecurityOrigin(),
81 UserGestureIndicator::processingUserGesture(), 81 UserGestureIndicator::processingUserGesture(),
82 convertToBaseCallback( 82 convertToBaseCallback(
83 WTF::bind(&NotificationManager::onPermissionRequestComplete, 83 WTF::bind(&NotificationManager::onPermissionRequestComplete,
84 wrapPersistent(this), wrapPersistent(resolver), 84 wrapPersistent(this), wrapPersistent(resolver),
85 wrapPersistent(deprecatedCallback)))); 85 wrapPersistent(deprecatedCallback))));
86 86
87 return promise; 87 return promise;
88 } 88 }
89 89
90 void NotificationManager::contextDestroyed() { 90 void NotificationManager::contextDestroyed() {
(...skipping 15 matching lines...) Expand all
106 void NotificationManager::onPermissionServiceConnectionError() { 106 void NotificationManager::onPermissionServiceConnectionError() {
107 m_permissionService.reset(); 107 m_permissionService.reset();
108 } 108 }
109 109
110 DEFINE_TRACE(NotificationManager) { 110 DEFINE_TRACE(NotificationManager) {
111 ContextLifecycleObserver::trace(visitor); 111 ContextLifecycleObserver::trace(visitor);
112 Supplement<ExecutionContext>::trace(visitor); 112 Supplement<ExecutionContext>::trace(visitor);
113 } 113 }
114 114
115 } // namespace blink 115 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/modules/geolocation/Geolocation.cpp ('k') | third_party/WebKit/Source/modules/permissions/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698