Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Side by Side Diff: content/renderer/media/media_permission_dispatcher.cc

Issue 2255933002: Add PermissionDescriptor to the permissions Mojo interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no_notification_dispatcher
Patch Set: Print the unexpected permission type. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/media/media_permission_dispatcher.h" 5 #include "content/renderer/media/media_permission_dispatcher.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/single_thread_task_runner.h" 9 #include "base/single_thread_task_runner.h"
10 #include "base/threading/thread_task_runner_handle.h" 10 #include "base/threading/thread_task_runner_handle.h"
11 #include "media/base/bind_to_current_loop.h" 11 #include "media/base/bind_to_current_loop.h"
12 #include "third_party/WebKit/public/web/WebUserGestureIndicator.h" 12 #include "third_party/WebKit/public/web/WebUserGestureIndicator.h"
13 #include "url/gurl.h" 13 #include "url/gurl.h"
14 14
15 namespace { 15 namespace {
16 16
17 using Type = media::MediaPermission::Type; 17 using Type = media::MediaPermission::Type;
18 18
19 blink::mojom::PermissionName MediaPermissionTypeToPermissionName(Type type) { 19 blink::mojom::PermissionDescriptorPtr MediaPermissionTypeToPermissionDescriptor(
20 Type type) {
21 auto descriptor = blink::mojom::PermissionDescriptor::New();
20 switch (type) { 22 switch (type) {
21 case Type::PROTECTED_MEDIA_IDENTIFIER: 23 case Type::PROTECTED_MEDIA_IDENTIFIER:
22 return blink::mojom::PermissionName::PROTECTED_MEDIA_IDENTIFIER; 24 descriptor->name =
25 blink::mojom::PermissionName::PROTECTED_MEDIA_IDENTIFIER;
26 break;
23 case Type::AUDIO_CAPTURE: 27 case Type::AUDIO_CAPTURE:
24 return blink::mojom::PermissionName::AUDIO_CAPTURE; 28 descriptor->name = blink::mojom::PermissionName::AUDIO_CAPTURE;
29 break;
25 case Type::VIDEO_CAPTURE: 30 case Type::VIDEO_CAPTURE:
26 return blink::mojom::PermissionName::VIDEO_CAPTURE; 31 descriptor->name = blink::mojom::PermissionName::VIDEO_CAPTURE;
32 break;
33 default:
34 NOTREACHED() << type;
35 descriptor->name =
36 blink::mojom::PermissionName::PROTECTED_MEDIA_IDENTIFIER;
27 } 37 }
28 NOTREACHED(); 38 return descriptor;
29 return blink::mojom::PermissionName::PROTECTED_MEDIA_IDENTIFIER;
30 } 39 }
31 40
32 } // namespace 41 } // namespace
33 42
34 namespace content { 43 namespace content {
35 44
36 MediaPermissionDispatcher::MediaPermissionDispatcher( 45 MediaPermissionDispatcher::MediaPermissionDispatcher(
37 const ConnectToServiceCB& connect_to_service_cb) 46 const ConnectToServiceCB& connect_to_service_cb)
38 : connect_to_service_cb_(connect_to_service_cb), 47 : connect_to_service_cb_(connect_to_service_cb),
39 task_runner_(base::ThreadTaskRunnerHandle::Get()), 48 task_runner_(base::ThreadTaskRunnerHandle::Get()),
(...skipping 25 matching lines...) Expand all
65 74
66 DCHECK(task_runner_->RunsTasksOnCurrentThread()); 75 DCHECK(task_runner_->RunsTasksOnCurrentThread());
67 76
68 if (!permission_service_) 77 if (!permission_service_)
69 connect_to_service_cb_.Run(mojo::GetProxy(&permission_service_)); 78 connect_to_service_cb_.Run(mojo::GetProxy(&permission_service_));
70 79
71 int request_id = RegisterCallback(permission_status_cb); 80 int request_id = RegisterCallback(permission_status_cb);
72 DVLOG(2) << __func__ << ": request ID " << request_id; 81 DVLOG(2) << __func__ << ": request ID " << request_id;
73 82
74 permission_service_->HasPermission( 83 permission_service_->HasPermission(
75 MediaPermissionTypeToPermissionName(type), url::Origin(security_origin), 84 MediaPermissionTypeToPermissionDescriptor(type),
85 url::Origin(security_origin),
76 base::Bind(&MediaPermissionDispatcher::OnPermissionStatus, weak_ptr_, 86 base::Bind(&MediaPermissionDispatcher::OnPermissionStatus, weak_ptr_,
77 request_id)); 87 request_id));
78 } 88 }
79 89
80 void MediaPermissionDispatcher::RequestPermission( 90 void MediaPermissionDispatcher::RequestPermission(
81 Type type, 91 Type type,
82 const GURL& security_origin, 92 const GURL& security_origin,
83 const PermissionStatusCB& permission_status_cb) { 93 const PermissionStatusCB& permission_status_cb) {
84 if (!task_runner_->RunsTasksOnCurrentThread()) { 94 if (!task_runner_->RunsTasksOnCurrentThread()) {
85 task_runner_->PostTask( 95 task_runner_->PostTask(
86 FROM_HERE, base::Bind(&MediaPermissionDispatcher::RequestPermission, 96 FROM_HERE, base::Bind(&MediaPermissionDispatcher::RequestPermission,
87 weak_ptr_, type, security_origin, 97 weak_ptr_, type, security_origin,
88 media::BindToCurrentLoop(permission_status_cb))); 98 media::BindToCurrentLoop(permission_status_cb)));
89 return; 99 return;
90 } 100 }
91 101
92 DCHECK(task_runner_->RunsTasksOnCurrentThread()); 102 DCHECK(task_runner_->RunsTasksOnCurrentThread());
93 103
94 if (!permission_service_) 104 if (!permission_service_)
95 connect_to_service_cb_.Run(mojo::GetProxy(&permission_service_)); 105 connect_to_service_cb_.Run(mojo::GetProxy(&permission_service_));
96 106
97 int request_id = RegisterCallback(permission_status_cb); 107 int request_id = RegisterCallback(permission_status_cb);
98 DVLOG(2) << __func__ << ": request ID " << request_id; 108 DVLOG(2) << __func__ << ": request ID " << request_id;
99 109
100 permission_service_->RequestPermission( 110 permission_service_->RequestPermission(
101 MediaPermissionTypeToPermissionName(type), url::Origin(security_origin), 111 MediaPermissionTypeToPermissionDescriptor(type),
112 url::Origin(security_origin),
102 blink::WebUserGestureIndicator::isProcessingUserGesture(), 113 blink::WebUserGestureIndicator::isProcessingUserGesture(),
103 base::Bind(&MediaPermissionDispatcher::OnPermissionStatus, weak_ptr_, 114 base::Bind(&MediaPermissionDispatcher::OnPermissionStatus, weak_ptr_,
104 request_id)); 115 request_id));
105 } 116 }
106 117
107 uint32_t MediaPermissionDispatcher::RegisterCallback( 118 uint32_t MediaPermissionDispatcher::RegisterCallback(
108 const PermissionStatusCB& permission_status_cb) { 119 const PermissionStatusCB& permission_status_cb) {
109 DCHECK(task_runner_->RunsTasksOnCurrentThread()); 120 DCHECK(task_runner_->RunsTasksOnCurrentThread());
110 121
111 uint32_t request_id = next_request_id_++; 122 uint32_t request_id = next_request_id_++;
(...skipping 12 matching lines...) Expand all
124 RequestMap::iterator iter = requests_.find(request_id); 135 RequestMap::iterator iter = requests_.find(request_id);
125 DCHECK(iter != requests_.end()) << "Request not found."; 136 DCHECK(iter != requests_.end()) << "Request not found.";
126 137
127 PermissionStatusCB permission_status_cb = iter->second; 138 PermissionStatusCB permission_status_cb = iter->second;
128 requests_.erase(iter); 139 requests_.erase(iter);
129 140
130 permission_status_cb.Run(status == blink::mojom::PermissionStatus::GRANTED); 141 permission_status_cb.Run(status == blink::mojom::PermissionStatus::GRANTED);
131 } 142 }
132 143
133 } // namespace content 144 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698