Turn Browser Context Menu Async

Turn Browser Context Menu Async

Update toolkit_delegate_views to launch the menu as async

TEST=manually testing the various ways of calling the context menu. Normal views, guest_views
BUG=557136
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/46ca4289f535d4ca013a6757b44c3d9ecaa31802
Cr-Commit-Position: refs/heads/master@{#415355}

[jonross, 2016-08-17 20:44:23]

The CQ bit was checked by jonross@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 20:44:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 21:28:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 21:28:36]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jonross, 2016-08-18 17:46:47]

Description was changed from

==========
Turn Browser Context Menu Async

Update toolkit_delegate_views to launch the menu as async

TEST=manually testing the various ways of calling the context menu. Normal
views, guest_views
BUG=557136
==========

to

==========
Turn Browser Context Menu Async

Update toolkit_delegate_views to launch the menu as async

TEST=manually testing the various ways of calling the context menu. Normal
views, guest_views
BUG=557136
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jonross, 2016-08-18 17:48:10]

The CQ bit was checked by jonross@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 17:48:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 20:13:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 20:13:30]

Dry run: This issue passed the CQ dry run.

[jonross, 2016-08-19 14:15:55]

jonross@chromium.org changed reviewers:
+ dtseng@chromium.org

[jonross, 2016-08-19 14:15:56]

Hi David,

Could you review my changes to background_test.extjs? They are based on your
suggestions yesterday, reflecting the lack of nested message loop in the menus.

Thanks.

[jonross, 2016-08-19 14:17:25]

jonross@chromium.org changed reviewers:
+ avi@chromium.org

[jonross, 2016-08-19 14:17:25]

avi@chromium.org: Please review changes in 

toolkit_delegate_views.cc

I am switching the menu from its current blocking call, to the async runtype.
This removes the nested message loop.

Thanks,
Jon

[David Tseng, 2016-08-19 15:05:16]

ChromeVox changes lgtm

[Avi (use Gerrit), 2016-08-21 04:37:53]

This looks plausible; LGTM.

Can you get some Views eyes on this? I'm not a Views peep.

[jonross, 2016-08-22 13:14:39]

Description was changed from

==========
Turn Browser Context Menu Async

Update toolkit_delegate_views to launch the menu as async

TEST=manually testing the various ways of calling the context menu. Normal
views, guest_views
BUG=557136
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Turn Browser Context Menu Async

Update toolkit_delegate_views to launch the menu as async

TEST=manually testing the various ways of calling the context menu. Normal
views, guest_views
BUG=557136
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jonross, 2016-08-22 13:14:39]

jonross@chromium.org changed reviewers:
+ sky@chromium.org

[jonross, 2016-08-22 13:15:17]

On 2016/08/21 04:37:53, Avi wrote:
> This looks plausible; LGTM.
> 
> Can you get some Views eyes on this? I'm not a Views peep.

+sky@ to approve the menu based change as he's reviewed the rest

[sky, 2016-08-30 16:40:44]

LGTM

[jonross, 2016-08-30 17:14:03]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2016-08-30 17:14:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 18:11:59]

Description was changed from

==========
Turn Browser Context Menu Async

Update toolkit_delegate_views to launch the menu as async

TEST=manually testing the various ways of calling the context menu. Normal
views, guest_views
BUG=557136
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Turn Browser Context Menu Async

Update toolkit_delegate_views to launch the menu as async

TEST=manually testing the various ways of calling the context menu. Normal
views, guest_views
BUG=557136
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-08-30 18:12:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-30 18:16:27]

Description was changed from

==========
Turn Browser Context Menu Async

Update toolkit_delegate_views to launch the menu as async

TEST=manually testing the various ways of calling the context menu. Normal
views, guest_views
BUG=557136
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Turn Browser Context Menu Async

Update toolkit_delegate_views to launch the menu as async

TEST=manually testing the various ways of calling the context menu. Normal
views, guest_views
BUG=557136
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/46ca4289f535d4ca013a6757b44c3d9ecaa31802
Cr-Commit-Position: refs/heads/master@{#415355}
==========

[commit-bot: I haz the power, 2016-08-30 18:16:29]

Patchset 2 (id:??) landed as
https://crrev.com/46ca4289f535d4ca013a6757b44c3d9ecaa31802
Cr-Commit-Position: refs/heads/master@{#415355}