Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1525)

Issue 2255893002: Revert of Fix jank during mac resize (Closed)

Created:
4 years, 4 months ago by enne (OOO)
Modified:
4 years, 4 months ago
CC:
ccameron, chromium-reviews, darin-cc_chromium.org, jam, no sievers
Base URL:
https://chromium.googlesource.com/chromium/src.git@fixhangoutsblank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix jank during mac resize (patchset #2 id:20001 of https://codereview.chromium.org/2246613002/ ) Reason for revert: Causes fullscreen flash videos to be all white on Mac BUG=638561 Original issue's description: > Fix jank during mac resize > > Allow SetNeedsBeginFrames messages to be handled on Mac during resize. > If this message is not handled, then the renderer says that it needs > frames but the message is ignored because of the resize lock. Then, the > browser never sends begin frame messages and the renderer then never is > able to produce a frame. This means that it can't produce a frame of > the right size before the resize lock times out and there's jank on > screen. > > R=ccameron@chromium.org,sievers@chromium.org > BUG=632603 > > Committed: https://crrev.com/ee0504e307d6ed18a94a96eae8a4b57adcff4b11 > Cr-Commit-Position: refs/heads/master@{#411806} TBR=asvitkine@chromium.org,ccameron@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=632603 Committed: https://crrev.com/403810b6f9fe48ae77b6f19fc2c7e413e2088a00 Cr-Commit-Position: refs/heads/master@{#412615}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M content/browser/renderer_host/render_message_filter.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
enne (OOO)
Created Revert of Fix jank during mac resize
4 years, 4 months ago (2016-08-17 19:00:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255893002/1
4 years, 4 months ago (2016-08-17 19:00:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 19:52:19 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 19:54:46 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/403810b6f9fe48ae77b6f19fc2c7e413e2088a00
Cr-Commit-Position: refs/heads/master@{#412615}

Powered by Google App Engine
This is Rietveld 408576698