Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2255863002: Fix SampleAndroidShadows warnings (Closed)

Created:
4 years, 4 months ago by f(malita)
Modified:
4 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M samplecode/SampleAndroidShadows.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
f(malita)
https://build.chromium.org/p/client.skia.android/builders/Perf-Android-Clang-Nexus9-CPU-Denver-Arm64-Release/builds/166/steps/compile_skia%20on%20Ubuntu/logs/stdio: FAILED: /usr/bin/ccache /b/work/skia/platform_tools/android/bin/../toolchains/arm64-r12b-21/bin/aarch64-linux-android-clang++ -MMD -MF obj/samplecode/viewer.SampleAndroidShadows.o.d -DSK_INTERNAL -DSK_GAMMA_APPLY_TO_A8 -DQT_NO_KEYWORDS -DSK_ALLOW_STATIC_GLOBAL_INITIALIZERS=0 -DSK_SUPPORT_GPU=1 -DSK_FORCE_DISTANCE_FIELD_TEXT=0 -DSK_HAS_GIF_LIBRARY -DSK_HAS_JPEG_LIBRARY ...
4 years, 4 months ago (2016-08-17 18:03:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255863002/1
4 years, 4 months ago (2016-08-17 18:04:09 UTC) #4
jvanverth1
lgtm
4 years, 4 months ago (2016-08-17 18:09:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255863002/1
4 years, 4 months ago (2016-08-17 18:32:34 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 18:33:31 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9da5dbdda3aec9875cdaa05c1815b4d8c17cb130

Powered by Google App Engine
This is Rietveld 408576698