|
|
DescriptionFix SampleAndroidShadows warnings
R=jvanverth@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255863002
NOTRY=true
Committed: https://skia.googlesource.com/skia/+/9da5dbdda3aec9875cdaa05c1815b4d8c17cb130
Patch Set 1 #
Messages
Total messages: 11 (6 generated)
Description was changed from ========== Fix SampleAndroidShadows warnings R=jvanverth@google.com,robertphillips@google.com ========== to ========== Fix SampleAndroidShadows warnings R=jvanverth@google.com,robertphillips@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255863002 ==========
https://build.chromium.org/p/client.skia.android/builders/Perf-Android-Clang-...: FAILED: /usr/bin/ccache /b/work/skia/platform_tools/android/bin/../toolchains/arm64-r12b-21/bin/aarch64-linux-android-clang++ -MMD -MF obj/samplecode/viewer.SampleAndroidShadows.o.d -DSK_INTERNAL -DSK_GAMMA_APPLY_TO_A8 -DQT_NO_KEYWORDS -DSK_ALLOW_STATIC_GLOBAL_INITIALIZERS=0 -DSK_SUPPORT_GPU=1 -DSK_FORCE_DISTANCE_FIELD_TEXT=0 -DSK_HAS_GIF_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_IS_BOT -DSK_CODEC_DECODES_RAW -DSK_TEST_QCMS -DSK_BUILD_FOR_ANDROID -DSK_GAMMA_EXPONENT=1.4 -DSK_GAMMA_CONTRAST=0.0 -DSKIA_DLL -DSKIA_IMPLEMENTATION=1 -DSK_SUPPORT_LEGACY_CLIPTOLAYERFLAG -DSK_XML -DNDEBUG -I../../../bench -I../../../gm -I../../../include/private -I../../../src/core -I../../../src/effects -I../../../src/gpu -I../../../src/image -I../../../src/images -I../../../src/pathops -I../../../src/views/unix -I../../../tools/timer -I../../../include/client/android -I../../../tools/debugger -I../../../src/effects/gradients -I../../../src/lazy -I../../../include/views -I../../../experimental -I../../../samplecode -I../../../tools -I../../../src/sksl -I../../../tools/gpu -I../../../third_party/lua/src -I../../../tools/flags -I../../../third_party/externals/jsoncpp/include -I../../../include/c -I../../../include/config -I../../../include/core -I../../../include/pathops -I../../../include/codec -I../../../include/android -I../../../include/effects -I../../../include/images -I../../../include/ports -I../../../third_party/qcms/src -I../../../src/sfnt -I../../../include/utils -I../../../src/utils -I../../../include/gpu -I../../../experimental/svg/model -I../../../include/xml -I../../../platform_tools/android/third_party/native_app_glue -I../../../third_party/libpng -I../../../third_party/externals/zlib -I../../../tools -fPIC -fno-exceptions -fstrict-aliasing -Wall -Wextra -Winit-self -Wpointer-arith -Wsign-compare -Wvla -Wno-unused-parameter -Werror -fuse-ld=gold -Wno-unknown-warning-option -Wno-tautological-compare -Wno-unused-command-line-argument -O2 -gline-tables-only -std=c++11 -fno-rtti -fno-threadsafe-statics -Wnon-virtual-dtor -c ../../../samplecode/SampleAndroidShadows.cpp -o obj/samplecode/viewer.SampleAndroidShadows.o ../../../samplecode/SampleAndroidShadows.cpp:185:39: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move] sk_sp<SkShader> gaussShader = std::move(SkGaussianEdgeShader::Make()); ^ ../../../samplecode/SampleAndroidShadows.cpp:185:39: note: remove std::move call here sk_sp<SkShader> gaussShader = std::move(SkGaussianEdgeShader::Make()); ^~~~~~~~~~ ~ ../../../samplecode/SampleAndroidShadows.cpp:305:39: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move] sk_sp<SkShader> gaussShader = std::move(SkGaussianEdgeShader::Make()); ^ ../../../samplecode/SampleAndroidShadows.cpp:305:39: note: remove std::move call here sk_sp<SkShader> gaussShader = std::move(SkGaussianEdgeShader::Make()); ^~~~~~~~~~ ~ 2 errors generated.
The CQ bit was checked by fmalita@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by fmalita@chromium.org
Description was changed from ========== Fix SampleAndroidShadows warnings R=jvanverth@google.com,robertphillips@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255863002 ========== to ========== Fix SampleAndroidShadows warnings R=jvanverth@google.com,robertphillips@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255863002 NOTRY=true ==========
The CQ bit was checked by fmalita@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix SampleAndroidShadows warnings R=jvanverth@google.com,robertphillips@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255863002 NOTRY=true ========== to ========== Fix SampleAndroidShadows warnings R=jvanverth@google.com,robertphillips@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255863002 NOTRY=true Committed: https://skia.googlesource.com/skia/+/9da5dbdda3aec9875cdaa05c1815b4d8c17cb130 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/9da5dbdda3aec9875cdaa05c1815b4d8c17cb130 |