Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2255833003: DO NOT COMMIT: hack hack hacking on preloading md-settings (Closed)

Created:
4 years, 4 months ago by Dan Beam
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, jam, michaelpg+watch-md-ui_chromium.org, darin-cc_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DO NOT COMMIT: hack hack hacking on preloading md-settings BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Patch Set 2 : <link rel=preload> #

Patch Set 3 : to show dave #

Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -68 lines) Patch
M chrome/browser/resources/settings/about_page/detailed_build_info.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_detail_page.html View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_page.html View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_apnlist.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_ip_config.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_nameservers.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_property_list.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_proxy.html View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_proxy_exclusions.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_proxy_input.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_siminfo.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_summary.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/languages_page/language_detail_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/languages_page/languages_page.html View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/languages_page/manage_input_methods_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/languages_page/manage_languages_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/users_page.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/prefs/prefs.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/settings.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_ui.h View 1 2 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_ui.cc View 1 2 4 chunks +143 lines, -16 lines 0 comments Download
M content/browser/webui/shared_resources_data_source.h View 1 chunk +8 lines, -1 line 0 comments Download
M content/browser/webui/shared_resources_data_source.cc View 5 chunks +10 lines, -11 lines 0 comments Download
M content/browser/webui/url_data_manager_backend.cc View 4 chunks +11 lines, -0 lines 0 comments Download
M content/browser/webui/web_ui_data_source_impl.h View 3 chunks +5 lines, -0 lines 0 comments Download
M content/browser/webui/web_ui_data_source_impl.cc View 3 chunks +11 lines, -0 lines 0 comments Download
M content/public/browser/url_data_source.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/public/browser/url_data_source.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/browser/web_ui_data_source.h View 3 chunks +7 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2251383002 Patch 1

Messages

Total messages: 2 (2 generated)
Dan Beam
Description was changed from ========== DO NOT COMMIT: hack hack hacking on preloading md-settings BUG= ...
4 years, 4 months ago (2016-08-18 00:51:45 UTC) #1
Dan Beam
3 years, 10 months ago (2017-02-18 06:00:02 UTC) #2 
Description was changed from

==========
DO NOT COMMIT: hack hack hacking on preloading md-settings

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
DO NOT COMMIT: hack hack hacking on preloading md-settings

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

Powered by Google App Engine
This is Rietveld 408576698