Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 225583009: Add Net.CertVerifier_First_Job_Latency metric. (Closed)

Created:
6 years, 8 months ago by davidben
Modified:
6 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

Add Net.CertVerifier_First_Job_Latency metric. Specifically counts only the first CertVerifer job in order to capture any initialization costs. BUG=361166 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262816

Patch Set 1 #

Total comments: 2

Patch Set 2 : sleevi comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -3 lines) Patch
M net/cert/multi_threaded_cert_verifier.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M net/cert/multi_threaded_cert_verifier.cc View 1 4 chunks +22 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
davidben
6 years, 8 months ago (2014-04-08 17:53:13 UTC) #1
Ryan Sleevi
https://codereview.chromium.org/225583009/diff/1/net/cert/multi_threaded_cert_verifier.cc File net/cert/multi_threaded_cert_verifier.cc (right): https://codereview.chromium.org/225583009/diff/1/net/cert/multi_threaded_cert_verifier.cc#newcode563 net/cert/multi_threaded_cert_verifier.cc:563: CertVerifierJob* job = j->second; Rather than at a bool ...
6 years, 8 months ago (2014-04-08 20:19:01 UTC) #2
davidben
https://codereview.chromium.org/225583009/diff/1/net/cert/multi_threaded_cert_verifier.cc File net/cert/multi_threaded_cert_verifier.cc (right): https://codereview.chromium.org/225583009/diff/1/net/cert/multi_threaded_cert_verifier.cc#newcode563 net/cert/multi_threaded_cert_verifier.cc:563: CertVerifierJob* job = j->second; On 2014/04/08 20:19:01, Ryan Sleevi ...
6 years, 8 months ago (2014-04-08 23:33:20 UTC) #3
Ryan Sleevi
lgtm
6 years, 8 months ago (2014-04-09 16:52:10 UTC) #4
Alexei Svitkine (slow)
lgtm
6 years, 8 months ago (2014-04-09 18:48:50 UTC) #5
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 8 months ago (2014-04-09 18:51:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/225583009/10001
6 years, 8 months ago (2014-04-09 18:52:19 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 21:13:44 UTC) #8
Message was sent while issue was closed.
Change committed as 262816

Powered by Google App Engine
This is Rietveld 408576698