Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 225583008: Silence git-hooks/pre-commit in the absence of .gitmodules (take 2). (Closed)

Created:
6 years, 8 months ago by Ami GONE FROM CHROMIUM
Modified:
6 years, 8 months ago
Reviewers:
szager1
CC:
chromium-reviews, spang
Visibility:
Public.

Description

Silence git-hooks/pre-commit in the absence of .gitmodules (take 2). Other projects use depot_tools (which pulls in this hook) and chromium's build/ (where the hook lives) but don't use git modules (e.g. webrtc). This first landed as r257470 but was accidentally undone by r259711. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261931

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/git-hooks/pre-commit View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Ami GONE FROM CHROMIUM
@szager: please review.
6 years, 8 months ago (2014-04-04 18:35:43 UTC) #1
szager1
lgtm
6 years, 8 months ago (2014-04-04 20:42:23 UTC) #2
Ami GONE FROM CHROMIUM
The CQ bit was checked by fischman@chromium.org
6 years, 8 months ago (2014-04-04 20:51:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/225583008/1
6 years, 8 months ago (2014-04-04 20:53:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/225583008/1
6 years, 8 months ago (2014-04-04 21:30:49 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-05 00:29:17 UTC) #6
Message was sent while issue was closed.
Change committed as 261931

Powered by Google App Engine
This is Rietveld 408576698