Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 225583006: Perform perlin noise matrix computations once per frame, not per pixel. (Closed)

Created:
6 years, 8 months ago by Stephen White
Modified:
6 years, 8 months ago
Reviewers:
sugoi1, sugoi
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Perform perlin noise matrix computations once per frame, not per pixel. Before (Retina MBP): running bench [640 480] perlinnoise 8888: cmsecs = 1853.18 After: running bench [640 480] perlinnoise 8888: cmsecs = 1667.06 Committed: https://code.google.com/p/skia/source/detail?r=14060

Patch Set 1 #

Patch Set 2 : Perform matrix computations once per frame, not one per span #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M src/effects/SkPerlinNoiseShader.cpp View 1 2 chunks +13 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Stephen White
sugoi@: PTAL. Thanks!
6 years, 8 months ago (2014-04-04 14:09:05 UTC) #1
sugoi
On 2014/04/04 14:09:05, Stephen White wrote: > sugoi@: PTAL. Thanks! LGTM
6 years, 8 months ago (2014-04-04 14:21:06 UTC) #2
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 8 months ago (2014-04-04 14:41:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/senorblanco@chromium.org/225583006/20001
6 years, 8 months ago (2014-04-04 14:41:12 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-04 14:41:13 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 8 months ago (2014-04-04 14:41:13 UTC) #6
Stephen White
6 years, 8 months ago (2014-04-04 14:46:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r14060 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698