Revert previous CL making PaintTabBackgroundUsingFillId() a non-method

Revert previous CL making PaintTabBackgroundUsingFillId() a non-method

BUG=621139
In preparation for https://codereview.chromium.org/2118853002/, two other
CLs were landed first.  Because the main CL was abandoned in favor of a
simpler approach, we are reverting one of these two preparatory CLs:

https://codereview.chromium.org/2197613002/ made major changes to the
prototype of PaintTabBackgroundUsingFillId() in order to force it to be
a non-method.  These and some related changes are now unnecessary, and
are being reverted here.  NOTE: The revert was done manually, so other
subsequent changes should be preserved.

(NOTE: https://codereview.chromium.org/2150013002/ moved a number of
static members and methods of the Tab class into the anonymous namespace,
along with a few methods that were "mostly static".  These changes are
considered a general code improvement, and are being left alone.)

Committed: https://crrev.com/95fa21d0ddf262b7c22233c842513c09c9f15d06
Cr-Commit-Position: refs/heads/master@{#412691}

[Greg Levin, 2016-08-17 16:22:32]

Description was changed from

==========
Revert previous CL making PaintTabBackgroundUsingFillId() a non-method

BUG=621139
==========

to

==========
Revert previous CL making PaintTabBackgroundUsingFillId() a non-method

BUG=621139

In preparation for https://codereview.chromium.org/2118853002/, two other
CLs were landed first.  Because the main CL was abandoned in favor of a
simpler approach, we are reverting one of these two preparatory CLs:

https://codereview.chromium.org/2197613002/ made major changes to the
prototype of PaintTabBackgroundUsingFillId() in order to force it to be
a non-method.  These and some related changes are now unnecessary, and
are being reverted here.  NOTE: The revert was done manually, so other
subsequent changes should be preserved.

(NOTE: https://codereview.chromium.org/2150013002/ moved a number of
static members and methods of the Tab class into the anonymous namespace,
along with a few methods that were "mostly static".  These changes are
considered a general code improvement, and are being left alone.)
==========

[Greg Levin, 2016-08-17 16:24:16]

glevin@chromium.org changed reviewers:
+ pkasting@chromium.org

[Greg Levin, 2016-08-17 16:24:17]

Please have a look!

[Peter Kasting, 2016-08-17 22:34:04]

LGTM

[Greg Levin, 2016-08-17 22:39:04]

The CQ bit was checked by glevin@chromium.org

[commit-bot: I haz the power, 2016-08-17 22:39:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 23:34:25]

Description was changed from

==========
Revert previous CL making PaintTabBackgroundUsingFillId() a non-method

BUG=621139

In preparation for https://codereview.chromium.org/2118853002/, two other
CLs were landed first.  Because the main CL was abandoned in favor of a
simpler approach, we are reverting one of these two preparatory CLs:

https://codereview.chromium.org/2197613002/ made major changes to the
prototype of PaintTabBackgroundUsingFillId() in order to force it to be
a non-method.  These and some related changes are now unnecessary, and
are being reverted here.  NOTE: The revert was done manually, so other
subsequent changes should be preserved.

(NOTE: https://codereview.chromium.org/2150013002/ moved a number of
static members and methods of the Tab class into the anonymous namespace,
along with a few methods that were "mostly static".  These changes are
considered a general code improvement, and are being left alone.)
==========

to

==========
Revert previous CL making PaintTabBackgroundUsingFillId() a non-method

BUG=621139

In preparation for https://codereview.chromium.org/2118853002/, two other
CLs were landed first.  Because the main CL was abandoned in favor of a
simpler approach, we are reverting one of these two preparatory CLs:

https://codereview.chromium.org/2197613002/ made major changes to the
prototype of PaintTabBackgroundUsingFillId() in order to force it to be
a non-method.  These and some related changes are now unnecessary, and
are being reverted here.  NOTE: The revert was done manually, so other
subsequent changes should be preserved.

(NOTE: https://codereview.chromium.org/2150013002/ moved a number of
static members and methods of the Tab class into the anonymous namespace,
along with a few methods that were "mostly static".  These changes are
considered a general code improvement, and are being left alone.)
==========

[commit-bot: I haz the power, 2016-08-17 23:34:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-17 23:40:10]

Description was changed from

==========
Revert previous CL making PaintTabBackgroundUsingFillId() a non-method

BUG=621139

In preparation for https://codereview.chromium.org/2118853002/, two other
CLs were landed first.  Because the main CL was abandoned in favor of a
simpler approach, we are reverting one of these two preparatory CLs:

https://codereview.chromium.org/2197613002/ made major changes to the
prototype of PaintTabBackgroundUsingFillId() in order to force it to be
a non-method.  These and some related changes are now unnecessary, and
are being reverted here.  NOTE: The revert was done manually, so other
subsequent changes should be preserved.

(NOTE: https://codereview.chromium.org/2150013002/ moved a number of
static members and methods of the Tab class into the anonymous namespace,
along with a few methods that were "mostly static".  These changes are
considered a general code improvement, and are being left alone.)
==========

to

==========
Revert previous CL making PaintTabBackgroundUsingFillId() a non-method

BUG=621139

In preparation for https://codereview.chromium.org/2118853002/, two other
CLs were landed first.  Because the main CL was abandoned in favor of a
simpler approach, we are reverting one of these two preparatory CLs:

https://codereview.chromium.org/2197613002/ made major changes to the
prototype of PaintTabBackgroundUsingFillId() in order to force it to be
a non-method.  These and some related changes are now unnecessary, and
are being reverted here.  NOTE: The revert was done manually, so other
subsequent changes should be preserved.

(NOTE: https://codereview.chromium.org/2150013002/ moved a number of
static members and methods of the Tab class into the anonymous namespace,
along with a few methods that were "mostly static".  These changes are
considered a general code improvement, and are being left alone.)

Committed: https://crrev.com/95fa21d0ddf262b7c22233c842513c09c9f15d06
Cr-Commit-Position: refs/heads/master@{#412691}
==========

[commit-bot: I haz the power, 2016-08-17 23:40:10]

Patchset 1 (id:??) landed as
https://crrev.com/95fa21d0ddf262b7c22233c842513c09c9f15d06
Cr-Commit-Position: refs/heads/master@{#412691}