chrome/browser/budget_service/budget.proto - Issue 2255813002: AddEngagementBudget and SpendBudget added to BudgetDatabase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/budget_service/budget.proto

Issue 2255813002: AddEngagementBudget and SpendBudget added to BudgetDatabase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added expiration check in SpendBudget Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/budget_service/budget.proto

diff --git a/chrome/browser/budget_service/budget.proto b/chrome/browser/budget_service/budget.proto

index e0c76e1655efc16c4872be19eafdf6285f785c66..0fc5a58de05459f81e36c7358a8308003a3cc6a7 100644

--- a/chrome/browser/budget_service/budget.proto

+++ b/chrome/browser/budget_service/budget.proto

@@ -9,10 +9,14 @@ package budget_service;

// Chrome requires this.

option optimize_for = LITE_RUNTIME;

-// Next available id: 2

+// Next available id: 3

message Budget {

// The sequence of budget chunks and their expiration times.

repeated BudgetChunk budget = 1;

+ // The timestamp of the last time that new budget was awarded. This stores

+ // the internal value needed to construct a base::Time object.

+ optional int64 last_updated = 2;

johnme 2016/08/19 18:48:35 Nit: rename this to clarify that only engagement a

harkness 2016/08/22 13:46:25 Done.

}

// Next available id: 3

« no previous file with comments | « no previous file | chrome/browser/budget_service/budget_database.h » ('j') | chrome/browser/budget_service/budget_database.h » ('J')