Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2255793002: [interpreter] Add CreateWithContext bytecode (Closed)

Created:
4 years, 4 months ago by klaasb
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Add CreateWithContext bytecode Generates a JSCreateWithContext node for TurboFan to optimize. BUG=v8:4280 LOG=n Committed: https://crrev.com/078842026e82eb6cb2532035befca5dc0def352d Cr-Commit-Position: refs/heads/master@{#38723}

Patch Set 1 #

Patch Set 2 : add to AllBytecodesGenerated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -9 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/WithStatement.golden View 1 chunk +4 lines, -4 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
klaasb
4 years, 4 months ago (2016-08-18 14:02:25 UTC) #8
Michael Starzinger
LGTM from my side.
4 years, 4 months ago (2016-08-18 14:52:45 UTC) #11
rmcilroy
lgtm
4 years, 4 months ago (2016-08-18 15:09:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255793002/20001
4 years, 4 months ago (2016-08-18 15:11:28 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-18 15:14:49 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 15:15:06 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/078842026e82eb6cb2532035befca5dc0def352d
Cr-Commit-Position: refs/heads/master@{#38723}

Powered by Google App Engine
This is Rietveld 408576698