Make the outdated build detector disabler load and run on XP.

Make the outdated build detector disabler load and run on XP.

This change:
- removes the dependency on base
- builds with cl.exe options to target old CPUs and runtimes
- drops GYP support
- drops building and testing on x64
- archives the tool and symbols on official builders

BUG=623986
Committed: https://crrev.com/3f0e4ff02d59664e584a9dff250f8a658b585653
Cr-Commit-Position: refs/heads/master@{#413080}

[grt (UTC plus 2), 2016-08-17 19:54:07]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 19:54:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 20:02:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 20:02:33]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[grt (UTC plus 2), 2016-08-18 08:54:28]

fix configs

[grt (UTC plus 2), 2016-08-18 08:55:01]

Description was changed from

==========
Make the outdated build detector disabler load and run on XP.

This change:
- removes the dependency on base
- builds with cl.exe options to target old CPUs and runtimes
- drops GYP support
- archives the tool and symbols on official builders

BUG=623986
==========

to

==========
Make the outdated build detector disabler load and run on XP.

This change:
- removes the dependency on base
- builds with cl.exe options to target old CPUs and runtimes
- drops GYP support
- drops building and testing on x64
- archives the tool and symbols on official builders

BUG=623986
==========

[grt (UTC plus 2), 2016-08-18 08:56:43]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 08:57:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 09:03:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 09:03:41]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[grt (UTC plus 2), 2016-08-18 12:18:56]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 12:19:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 12:24:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 12:25:00]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[grt (UTC plus 2), 2016-08-18 13:10:36]

grt@chromium.org changed reviewers:
+ dpranke@chromium.org

[grt (UTC plus 2), 2016-08-18 13:12:04]

grt@chromium.org changed reviewers:
+ ganesh@chromium.org

[grt (UTC plus 2), 2016-08-18 13:14:27]

The motivation for this change is to get a ToT build through our official build
and signing process. PTAL, thanks.

[Dirk Pranke, 2016-08-18 17:04:56]

lgtm

https://codereview.chromium.org/2255783003/diff/40001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2255783003/diff/40001/BUILD.gn#newcode114
BUILD.gn:114: deps += [
"//chrome/tools/disable_outdated_build_detector:disable_outdated_build_detector"
]
This should just be "//chrome/tools/disable_outdated_build_detector" (the target
name defaults to the directory name if not specified, and that form is preferred
because it's shorter).

[S. Ganesh, 2016-08-18 18:37:53]

lgtm

[grt (UTC plus 2), 2016-08-18 20:33:08]

Thanks

https://codereview.chromium.org/2255783003/diff/40001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2255783003/diff/40001/BUILD.gn#newcode114
BUILD.gn:114: deps += [
"//chrome/tools/disable_outdated_build_detector:disable_outdated_build_detector"
]
On 2016/08/18 17:04:56, Dirk Pranke wrote:
> This should just be "//chrome/tools/disable_outdated_build_detector" (the
target
> name defaults to the directory name if not specified, and that form is
preferred
> because it's shorter).

Done. Thanks for the clarification. I wasn't sure if the unqualified form mean
"all" or "first" or what. Is this documented in "gn help" somewhere (just
curious)?

[grt (UTC plus 2), 2016-08-18 20:33:16]

The CQ bit was checked by grt@chromium.org

[grt (UTC plus 2), 2016-08-18 20:33:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, ganesh@chromium.org
Link to the patchset: https://codereview.chromium.org/2255783003/#ps60001
(title: "BUILD.gn simplification")

[commit-bot: I haz the power, 2016-08-18 20:34:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 20:42:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 20:42:30]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[grt (UTC plus 2), 2016-08-19 06:50:13]

The CQ bit was checked by grt@chromium.org

[grt (UTC plus 2), 2016-08-19 06:50:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, ganesh@chromium.org
Link to the patchset: https://codereview.chromium.org/2255783003/#ps80001
(title: "suppress wstring warnings")

[commit-bot: I haz the power, 2016-08-19 06:50:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 07:51:30]

Description was changed from

==========
Make the outdated build detector disabler load and run on XP.

This change:
- removes the dependency on base
- builds with cl.exe options to target old CPUs and runtimes
- drops GYP support
- drops building and testing on x64
- archives the tool and symbols on official builders

BUG=623986
==========

to

==========
Make the outdated build detector disabler load and run on XP.

This change:
- removes the dependency on base
- builds with cl.exe options to target old CPUs and runtimes
- drops GYP support
- drops building and testing on x64
- archives the tool and symbols on official builders

BUG=623986
==========

[commit-bot: I haz the power, 2016-08-19 07:51:31]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-19 07:53:05]

Description was changed from

==========
Make the outdated build detector disabler load and run on XP.

This change:
- removes the dependency on base
- builds with cl.exe options to target old CPUs and runtimes
- drops GYP support
- drops building and testing on x64
- archives the tool and symbols on official builders

BUG=623986
==========

to

==========
Make the outdated build detector disabler load and run on XP.

This change:
- removes the dependency on base
- builds with cl.exe options to target old CPUs and runtimes
- drops GYP support
- drops building and testing on x64
- archives the tool and symbols on official builders

BUG=623986

Committed: https://crrev.com/3f0e4ff02d59664e584a9dff250f8a658b585653
Cr-Commit-Position: refs/heads/master@{#413080}
==========

[commit-bot: I haz the power, 2016-08-19 07:53:06]

Patchset 5 (id:??) landed as
https://crrev.com/3f0e4ff02d59664e584a9dff250f8a658b585653
Cr-Commit-Position: refs/heads/master@{#413080}

[Reid Kleckner, 2016-08-20 15:30:44]

rnk@chromium.org changed reviewers:
+ rnk@chromium.org

[Reid Kleckner, 2016-08-20 15:30:45]

https://codereview.chromium.org/2255783003/diff/80001/chrome/tools/disable_ou...
File chrome/tools/disable_outdated_build_detector/BUILD.gn (right):

https://codereview.chromium.org/2255783003/diff/80001/chrome/tools/disable_ou...
chrome/tools/disable_outdated_build_detector/BUILD.gn:13:
"NTDDI_VERSION=0x05010200",
This define conflicts with the global one:
https://cs.chromium.org/chromium/src/build/config/win/BUILD.gn?q=NTDDI_VERSIO...

We're getting -Wmacro-redefined warnings on clang buildbots:
https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan/builds/3989/step...

FAILED: obj/chrome/tools/disable_outdated_build_detector/lib/constants.obj
...
In file included from <built-in>:322:
<command line>(54,9):  error: 'NTDDI_VERSION' macro redefined
[-Werror,-Wmacro-redefined]
#define NTDDI_VERSION 0x05010200
        ^
<command line>(42,9):  note: previous definition is here
#define NTDDI_VERSION 0x0A000000
        ^

[grt (UTC plus 2), 2016-08-20 15:43:59]

https://codereview.chromium.org/2255783003/diff/80001/chrome/tools/disable_ou...
File chrome/tools/disable_outdated_build_detector/BUILD.gn (right):

https://codereview.chromium.org/2255783003/diff/80001/chrome/tools/disable_ou...
chrome/tools/disable_outdated_build_detector/BUILD.gn:13:
"NTDDI_VERSION=0x05010200",
On 2016/08/20 15:30:45, Reid Kleckner wrote:
> This define conflicts with the global one:
>
https://cs.chromium.org/chromium/src/build/config/win/BUILD.gn?q=NTDDI_VERSIO...
> 
> We're getting -Wmacro-redefined warnings on clang buildbots:
>
https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan/builds/3989/step...
> 
> FAILED: obj/chrome/tools/disable_outdated_build_detector/lib/constants.obj
> ...
> In file included from <built-in>:322:
> <command line>(54,9):  error: 'NTDDI_VERSION' macro redefined
> [-Werror,-Wmacro-redefined]
> #define NTDDI_VERSION 0x05010200
>         ^
> <command line>(42,9):  note: previous definition is here
> #define NTDDI_VERSION 0x0A000000
>         ^

I was afraid of that. There's no easy way around it, as the original definition
is in here:
https://cs.chromium.org/chromium/src/build/config/win/BUILD.gn?dr=C&q=runtime....

Can we live with it for a short time, or disable the warning on these targets?