components/ntp_snippets/ntp_snippets_fetcher.cc - Issue 2255783002: Support server categories in NTPSnippetsService.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/ntp_snippets/ntp_snippets_fetcher.cc

Issue 2255783002: Support server categories in NTPSnippetsService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Empty category handling. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/ntp_snippets/ntp_snippets_database.cc ('k') | components/ntp_snippets/ntp_snippets_service.h » ('j') | components/ntp_snippets/ntp_snippets_service.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/ntp_snippets/ntp_snippets_fetcher.h"	5 #include "components/ntp_snippets/ntp_snippets_fetcher.h"

6	6

7 #include <stdlib.h>	7 #include <stdlib.h>

8	8

9 #include "base/command_line.h"	9 #include "base/command_line.h"

10 #include "base/files/file_path.h"	10 #include "base/files/file_path.h"

(...skipping 578 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
589 // a network request, so don't record FetchTime in those cases.	589 // a network request, so don't record FetchTime in those cases.

590 if (result != FetchResult::EMPTY_HOSTS &&	590 if (result != FetchResult::EMPTY_HOSTS &&

591 result != FetchResult::OAUTH_TOKEN_ERROR) {	591 result != FetchResult::OAUTH_TOKEN_ERROR) {

592 UMA_HISTOGRAM_TIMES("NewTabPage.Snippets.FetchTime",	592 UMA_HISTOGRAM_TIMES("NewTabPage.Snippets.FetchTime",

593 tick_clock_->NowTicks() - fetch_start_time_);	593 tick_clock_->NowTicks() - fetch_start_time_);

594 }	594 }

595 UMA_HISTOGRAM_ENUMERATION("NewTabPage.Snippets.FetchResult",	595 UMA_HISTOGRAM_ENUMERATION("NewTabPage.Snippets.FetchResult",

596 static_cast<int>(result),	596 static_cast<int>(result),

597 static_cast<int>(FetchResult::RESULT_MAX));	597 static_cast<int>(FetchResult::RESULT_MAX));

598	598

	599 DVLOG(1) << "Fetch finished: " << last_status_;

599 if (!snippets_available_callback_.is_null())	600 if (!snippets_available_callback_.is_null())

600 snippets_available_callback_.Run(std::move(snippets));	601 snippets_available_callback_.Run(std::move(snippets));

601 }	602 }

602	603

603 } // namespace ntp_snippets	604 } // namespace ntp_snippets

OLD	NEW