Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: net/quic/chromium/quic_connection_logger.cc

Issue 2255753003: Remove unused histograms for QUIC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/quic_connection_logger.cc
diff --git a/net/quic/chromium/quic_connection_logger.cc b/net/quic/chromium/quic_connection_logger.cc
index df5c499b5b812c37b72fc3d8f39a4021d728d63f..bd09e828abf8f12e2601c3e81c8406d2259ee2a2 100644
--- a/net/quic/chromium/quic_connection_logger.cc
+++ b/net/quic/chromium/quic_connection_logger.cc
@@ -792,8 +792,6 @@ void QuicConnectionLogger::RecordLossHistograms() const {
base::HistogramBase* is_not_ack_histogram =
GetPacketNumberHistogram("IsNotAck_");
- base::HistogramBase* is_an_ack_histogram =
- GetPacketNumberHistogram("IsAnAck_");
base::HistogramBase* packet_arrived_histogram =
GetPacketNumberHistogram("Ack_");
base::HistogramBase* packet_missing_histogram =
@@ -817,9 +815,7 @@ void QuicConnectionLogger::RecordLossHistograms() const {
// Zero is an invalid packet sequence number.
DCHECK(!received_packets_[0]);
for (size_t i = 1; i <= last_index; ++i) {
- if (received_acks_[i])
- is_an_ack_histogram->Add(i);
- else
+ if (!received_acks_[i])
is_not_ack_histogram->Add(i);
packet_pattern_21 >>= 1;
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698