Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc

Issue 2255753002: Disable SecurityStyleChangedTest.SecurityStyleChangedObserverGoBack on ChromeOS due to flakiness. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc
diff --git a/chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc b/chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc
index 3cd98ca1e11174431995382b62bedf4d8191f491..ca2331d233787e1ef7e3248a842871cc0158acd7 100644
--- a/chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc
+++ b/chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc
@@ -992,8 +992,16 @@ IN_PROC_BROWSER_TEST_F(SecurityStyleChangedTest, SecurityStyleChangedObserver) {
// Visit a valid HTTPS page, then a broken HTTPS page, and then go back,
// and test that the observed security style matches.
+#if defined(OS_CHROMEOS)
+// Flaky on Chrome OS. See https://crbug.com/638576.
+#define MAYBE_SecurityStyleChangedObserverGoBack \
+ DISABLED_SecurityStyleChangedObserverGoBack
+#else
+#define MAYBE_SecurityStyleChangedObserverGoBack \
+ SecurityStyleChangedObserverGoBack
+#endif
IN_PROC_BROWSER_TEST_F(SecurityStyleChangedTest,
- SecurityStyleChangedObserverGoBack) {
+ MAYBE_SecurityStyleChangedObserverGoBack) {
ASSERT_TRUE(https_server_.Start());
net::EmbeddedTestServer https_test_server_expired(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698