Effectively disable foreign fetch when third party cookies are disabled.

Effectively disable foreign fetch when third party cookies are disabled.

This adds a check to make sure that the origin of the service worker is allowed
to run in the context of the "first party for cookies" (i.e. top-level document)
before starting it to handle a foreign fetch event. This makes sure service
workers with foreign fetch can't be used to bypass third-party cookie blocking.

BUG=540509
Committed: https://crrev.com/95e6429a2a60521f4d14b1d007d2ebfa02a9d370
Cr-Commit-Position: refs/heads/master@{#412748}

[Marijn Kruisselbrink, 2016-08-17 22:16:37]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 22:17:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marijn Kruisselbrink, 2016-08-17 22:39:56]

mek@chromium.org changed reviewers:
+ michaeln@chromium.org

[michaeln, 2016-08-17 23:20:43]

lgtm!

https://codereview.chromium.org/2255713003/diff/1/content/browser/service_wor...
File content/browser/service_worker/foreign_fetch_request_handler.cc (right):

https://codereview.chromium.org/2255713003/diff/1/content/browser/service_wor...
content/browser/service_worker/foreign_fetch_request_handler.cc:269:
target_worker_ = nullptr;
maybe null out resource_context_ here too

[Marijn Kruisselbrink, 2016-08-17 23:29:47]

https://codereview.chromium.org/2255713003/diff/1/content/browser/service_wor...
File content/browser/service_worker/foreign_fetch_request_handler.cc (right):

https://codereview.chromium.org/2255713003/diff/1/content/browser/service_wor...
content/browser/service_worker/foreign_fetch_request_handler.cc:269:
target_worker_ = nullptr;
On 2016/08/17 at 23:20:43, michaeln wrote:
> maybe null out resource_context_ here too

Done

[Marijn Kruisselbrink, 2016-08-17 23:29:50]

The CQ bit was checked by mek@chromium.org

[Marijn Kruisselbrink, 2016-08-17 23:29:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaeln@chromium.org
Link to the patchset: https://codereview.chromium.org/2255713003/#ps20001
(title: "null out resource_context_")

[commit-bot: I haz the power, 2016-08-17 23:30:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 02:46:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 02:46:39]

Exceeded global retry quota

[Marijn Kruisselbrink, 2016-08-18 03:50:03]

The CQ bit was checked by mek@chromium.org

[commit-bot: I haz the power, 2016-08-18 03:50:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 05:16:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-18 05:18:58]

Description was changed from

==========
Effectively disable foreign fetch when third party cookies are disabled.

This adds a check to make sure that the origin of the service worker is allowed
to run in the context of the "first party for cookies" (i.e. top-level document)
before starting it to handle a foreign fetch event. This makes sure service
workers with foreign fetch can't be used to bypass third-party cookie blocking.

BUG=540509
==========

to

==========
Effectively disable foreign fetch when third party cookies are disabled.

This adds a check to make sure that the origin of the service worker is allowed
to run in the context of the "first party for cookies" (i.e. top-level document)
before starting it to handle a foreign fetch event. This makes sure service
workers with foreign fetch can't be used to bypass third-party cookie blocking.

BUG=540509

Committed: https://crrev.com/95e6429a2a60521f4d14b1d007d2ebfa02a9d370
Cr-Commit-Position: refs/heads/master@{#412748}
==========

[commit-bot: I haz the power, 2016-08-18 05:18:59]

Patchset 2 (id:??) landed as
https://crrev.com/95e6429a2a60521f4d14b1d007d2ebfa02a9d370
Cr-Commit-Position: refs/heads/master@{#412748}