Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

Issue 2255683005: Determine if OffscreenCanvas is paintable in different rendering contexts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Canvas2DTypecast
Patch Set: enum Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp b/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
index 0e451a551665448efc2cd2f1f11dc329eed9a052..e02e37c6212d3deb6330be6fa6ded8b4f20b440a 100644
--- a/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
@@ -86,14 +86,6 @@ namespace {
const int DefaultWidth = 300;
const int DefaultHeight = 150;
-// Firefox limits width/height to 32767 pixels, but slows down dramatically before it
-// reaches that limit. We limit by area instead, giving us larger maximum dimensions,
-// in exchange for a smaller maximum canvas size.
-const int MaxCanvasArea = 32768 * 8192; // Maximum canvas area in CSS pixels
-
-// In Skia, we will also limit width/height to 32767.
-const int MaxSkiaDim = 32767; // Maximum width/height in CSS pixels.
-
#if OS(ANDROID)
// We estimate that the max limit for android phones is a quarter of that for
// desktops based on local experimental results on Android One.
@@ -119,22 +111,9 @@ const int UndefinedQualityValue = -1.0;
// Default image mime type for toDataURL and toBlob functions
const char DefaultMimeType[] = "image/png";
-bool canCreateImageBuffer(const IntSize& size)
-{
- if (size.isEmpty())
- return false;
- CheckedNumeric<int> area = size.width();
- area *= size.height();
- if (!area.IsValid() || area.ValueOrDie() > MaxCanvasArea)
- return false;
- if (size.width() > MaxSkiaDim || size.height() > MaxSkiaDim)
- return false;
- return true;
-}
-
PassRefPtr<Image> createTransparentImage(const IntSize& size)
{
- DCHECK(canCreateImageBuffer(size));
+ DCHECK(ImageBuffer::canCreateImageBuffer(size));
sk_sp<SkSurface> surface = SkSurface::MakeRasterN32Premul(size.width(), size.height());
return StaticBitmapImage::create(fromSkSp(surface->makeImageSnapshot()));
}
@@ -276,7 +255,7 @@ bool HTMLCanvasElement::shouldBeDirectComposited() const
bool HTMLCanvasElement::isPaintable() const
{
if (!m_context)
- return canCreateImageBuffer(size());
+ return ImageBuffer::canCreateImageBuffer(size());
return buffer();
}
@@ -895,7 +874,7 @@ void HTMLCanvasElement::createImageBufferInternal(std::unique_ptr<ImageBufferSur
m_didFailToCreateImageBuffer = true;
m_imageBufferIsClear = true;
- if (!canCreateImageBuffer(size()))
+ if (!ImageBuffer::canCreateImageBuffer(size()))
return;
int msaaSampleCount = 0;

Powered by Google App Engine
This is Rietveld 408576698